From: Alexey Dobriyan <adobriyan@gmail.com>
To: akpm@osdl.org
Cc: peterc@gelato.unsw.edu.au, tony.luck@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: pcdp-build-fix.patch added to -mm tree
Date: Tue, 31 May 2005 20:22:44 +0400 [thread overview]
Message-ID: <200505312022.44479.adobriyan@gmail.com> (raw)
In-Reply-To: <200505310925.j4V9PNoS009318@shell0.pdx.osdl.net>
On Tuesday 31 May 2005 13:24, akpm@osdl.org wrote:
> --- 25/drivers/firmware/pcdp.c~pcdp-build-fix
> +++ 25-akpm/drivers/firmware/pcdp.c
> @@ -11,6 +11,7 @@
> * published by the Free Software Foundation.
> */
>
> +#include <linux/config.h>
> #include <linux/acpi.h>
Does this patch make sense?
===========================
Recent restoration of quirk_via_irqpic() #ifdef'fed whole include/linux/acpi.h
with CONFIG_ACPI. So, if acpi.h is unlucky enough to be included before
config.h, bad things happen:
[tested, patch fixes the warning]
drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
drivers/serial/8250_acpi.c:51: warning: implicit declaration of
function `acpi_register_gsi'
or even
[untested]
In file included from drivers/firmware/pcdp.c:18:
drivers/firmware/pcdp.h:48: error: field 'addr' has incomplete type
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
--- linux-vanilla/include/linux/acpi.h 2005-05-28 02:59:59.000000000 +0400
+++ linux-8250/include/linux/acpi.h 2005-05-28 03:39:25.000000000 +0400
@@ -25,6 +25,8 @@
#ifndef _LINUX_ACPI_H
#define _LINUX_ACPI_H
+#include <linux/config.h>
+
#ifdef CONFIG_ACPI
#ifndef _LINUX
next parent reply other threads:[~2005-05-31 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200505310925.j4V9PNoS009318@shell0.pdx.osdl.net>
2005-05-31 16:22 ` Alexey Dobriyan [this message]
2005-05-31 19:36 ` pcdp-build-fix.patch added to -mm tree Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505312022.44479.adobriyan@gmail.com \
--to=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterc@gelato.unsw.edu.au \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.