From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: "David S. Miller" <davem@davemloft.net>, netdev <netdev@oss.sgi.com>
Subject: Re: PATCH: ioctl send PID in netlink events
Date: Fri, 3 Jun 2005 03:00:59 +0200 [thread overview]
Message-ID: <20050603010059.GU15391@postel.suug.ch> (raw)
In-Reply-To: <1117720349.6050.59.camel@localhost.localdomain>
> Index: net/ipv4/devinet.c
> ===================================================================
> --- e4f7366a04d973a42a948d3b4175d66e9adf143e/net/ipv4/devinet.c (mode:100644)
> +++ uncommitted/net/ipv4/devinet.c (mode:100644)
> @@ -236,6 +236,7 @@
> struct in_ifaddr *promote = NULL;
> struct in_ifaddr *ifa1 = *ifap;
>
> + printk("inet_del_ifa: pid %d\n",current->pid);
> ASSERT_RTNL();
>
> /* 1. Deleting primary ifaddr forces deletion all secondaries
> @@ -305,6 +306,7 @@
>
> ASSERT_RTNL();
>
> + printk("inet_insert_ifa: pid %d\n",current->pid);
> if (!ifa->ifa_local) {
> inet_free_ifa(ifa);
> return 0;
Don't you want to remove these?
> Index: net/ipv4/fib_semantics.c
> ===================================================================
> --- e4f7366a04d973a42a948d3b4175d66e9adf143e/net/ipv4/fib_semantics.c (mode:100644)
> +++ uncommitted/net/ipv4/fib_semantics.c (mode:100644)
> @@ -276,7 +276,7 @@
> struct nlmsghdr *n, struct netlink_skb_parms *req)
> {
> struct sk_buff *skb;
> - u32 pid = req ? req->pid : 0;
> + u32 pid = req ? req->pid : n->nlmsg_pid;
> int size = NLMSG_SPACE(sizeof(struct rtmsg)+256);
>
> skb = alloc_skb(size, GFP_KERNEL);
> @@ -1035,7 +1035,7 @@
> }
>
> nl->nlmsg_flags = NLM_F_REQUEST;
> - nl->nlmsg_pid = 0;
> + nl->nlmsg_pid = current->pid;
> nl->nlmsg_seq = 0;
> nl->nlmsg_len = NLMSG_LENGTH(sizeof(*rtm));
> if (cmd == SIOCDELRT) {
Neat ;->
next prev parent reply other threads:[~2005-06-03 1:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-02 13:52 PATCH: ioctl send PID in netlink events jamal
2005-06-03 1:00 ` Thomas Graf [this message]
2005-06-03 1:37 ` jamal
2005-06-03 3:32 ` jamal
2005-06-03 5:09 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050603010059.GU15391@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.