All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl@pobox.com>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Cc: ppc64 dev list <linuxppc64-dev@ozlabs.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Martin J. Bligh" <mbligh@mbligh.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	roland@topspin.com
Subject: [PATCH] prom_find_machine_type typo breaks pSeries lpar boot
Date: Fri, 3 Jun 2005 14:25:25 -0500	[thread overview]
Message-ID: <20050603192525.GC11355@otto> (raw)
In-Reply-To: <52vf4vuum5.fsf@topspin.com>

Typo in prom_find_machine_type from Ben's recent patch "ppc64: Fix
result code handling in prom_init" prevents pSeries LPAR systems from
booting.

Tested on a pSeries 570 and OpenPower 720 (both Power5 LPAR).

Signed-off-by: Nathan Lynch <ntl@pobox.com>

 arch/ppc64/kernel/prom_init.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.12-rc5-git8/arch/ppc64/kernel/prom_init.c
===================================================================
--- linux-2.6.12-rc5-git8.orig/arch/ppc64/kernel/prom_init.c
+++ linux-2.6.12-rc5-git8/arch/ppc64/kernel/prom_init.c
@@ -1370,7 +1370,7 @@ static int __init prom_find_machine_type
 	}
 	/* Default to pSeries. We need to know if we are running LPAR */
 	rtas = call_prom("finddevice", 1, 1, ADDR("/rtas"));
-	if (!PHANDLE_VALID(rtas)) {
+	if (PHANDLE_VALID(rtas)) {
 		int x = prom_getproplen(rtas, "ibm,hypertas-functions");
 		if (x != PROM_ERROR) {
 			prom_printf("Hypertas detected, assuming LPAR !\n");

  reply	other threads:[~2005-06-03 19:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-03 14:52 2.6.12-rc5-git8 regression on PPC64 Martin J. Bligh
2005-06-03 17:42 ` Roland Dreier
2005-06-03 18:27   ` Nathan Lynch
2005-06-03 19:07     ` Roland Dreier
2005-06-03 19:25       ` Nathan Lynch [this message]
2005-06-03 22:58         ` [PATCH] prom_find_machine_type typo breaks pSeries lpar boot Benjamin Herrenschmidt
2007-11-14 12:27           ` B. N. Poornima
2007-11-14 19:37             ` Nathan Lynch
2007-11-16 10:10               ` B. N. Poornima
2007-11-14 22:13             ` Benjamin Herrenschmidt
2005-06-03 22:56     ` 2.6.12-rc5-git8 regression on PPC64 Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050603192525.GC11355@otto \
    --to=ntl@pobox.com \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=mbligh@mbligh.org \
    --cc=roland@topspin.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.