All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [patch] wireless: char* -> char[] conversion in airo.c
Date: Sat, 04 Jun 2005 16:05:33 +0000	[thread overview]
Message-ID: <200506042005.33955.adobriyan@gmail.com> (raw)
In-Reply-To: <20050604150603.GD9687@nd47.coderock.org>

On Saturday 04 June 2005 19:06, Domen Puncer wrote:
> This conversion makes code from line 7101 right:
> 	if (copy_to_user(com.data, swversion, sizeof(swversion)))
> 
> size output (before, after):
>   55416    2228     160   57804    e1cc drivers/net/wireless/airo.o
>   55412    2228     160   57800    e1c8 drivers/net/wireless/airo.o

> --- c/drivers/net/wireless/airo.c
> +++ a/drivers/net/wireless/airo.c

> +static char swversion[] = "2.1";

Looks good.

2.95.3:
	   text	   data	    bss	    dec	    hex	filename
before	  51118	   2156	    160	  53434	   d0ba	drivers/net/wireless/airo.o
after	  51118	   2156	    160	  53434	   d0ba	drivers/net/wireless/airo.o

You won't fool him. :-)

3.3.5-20050130:
before	  46999	   2156	    160	  49315	   c0a3	drivers/net/wireless/airo.o
after	  46994	   2156	    160	  49310	   c09e	drivers/net/wireless/airo.o

4.1.0-20050522:
before	  45555	   2220	    160	  47935	   bb3f	drivers/net/wireless/airo.o
after	  45550	   2220	    160	  47930	   bb3a	drivers/net/wireless/airo.o
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2005-06-04 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-04 15:06 [KJ] [patch] wireless: char* -> char[] conversion in airo.c Domen Puncer
2005-06-04 16:05 ` Alexey Dobriyan [this message]
2005-06-04 16:38 ` randy_dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200506042005.33955.adobriyan@gmail.com \
    --to=adobriyan@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.