From: Greg KH <gregkh@suse.de>
To: Roland Dreier <roland@topspin.com>
Cc: Dave Jones <davej@redhat.com>,
Grant Grundler <grundler@parisc-linux.org>,
tom.l.nguyen@intel.com, linux-pci@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: pci_enable_msi() for everyone?
Date: Mon, 6 Jun 2005 22:22:03 -0700 [thread overview]
Message-ID: <20050607052202.GD17734@suse.de> (raw)
In-Reply-To: <5264wrj9l3.fsf@topspin.com>
On Mon, Jun 06, 2005 at 05:26:32PM -0700, Roland Dreier wrote:
>
> davej> What if MSI support has been disabled in the bridge due to
> davej> some quirk (like the recent AMD 8111 quirk) ? Maybe the
> davej> above function should check pci_msi_enable as well ?
>
> Greg> Yes, you are correct. I said it wasn't tested :)
>
> Huh? If a host bridge doesn't support MSI, and a device below it has
> its MSI capability enabled, we're in big trouble. Because that device
> is going to send interrupt messages whether the bridge likes it or
> not.
No, that device would never get MSI enabled on it. See the patch I
posted to make sure I didn't get it wrong...
thanks,
greg k-h
next prev parent reply other threads:[~2005-06-07 5:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 22:45 pci_enable_msi() for everyone? Greg KH
2005-06-03 23:16 ` Jeff Garzik
2005-06-04 0:01 ` Benjamin Herrenschmidt
2005-06-04 0:08 ` Jeff Garzik
2005-06-04 0:16 ` Benjamin Herrenschmidt
2005-06-04 0:34 ` Jeff Garzik
2005-06-04 6:51 ` Greg KH
2005-06-03 23:36 ` Roland Dreier
2005-06-06 22:58 ` Greg KH
2005-06-07 0:23 ` Roland Dreier
2005-06-07 5:19 ` Greg KH
2005-06-04 1:31 ` Grant Grundler
2005-06-04 6:48 ` Greg KH
2005-06-04 7:05 ` Grant Grundler
2005-06-04 7:18 ` Greg KH
2005-06-04 7:23 ` Dave Jones
2005-06-04 14:58 ` Roland Dreier
2005-06-06 23:01 ` Greg KH
2005-06-07 0:26 ` Roland Dreier
2005-06-07 5:22 ` Greg KH [this message]
2005-06-07 5:46 ` Adam Belay
2005-06-07 17:43 ` Luben Tuikov
2005-06-05 22:00 ` Benjamin Herrenschmidt
2005-06-06 23:00 ` Greg KH
2005-06-06 23:56 ` Benjamin Herrenschmidt
2005-06-05 19:46 ` David S. Miller
2005-06-06 22:55 ` Greg KH
2005-06-06 22:59 ` David S. Miller
2005-06-06 23:09 ` Greg KH
2005-06-06 23:08 ` Jeff Garzik
2005-06-06 23:10 ` David S. Miller
2005-06-06 23:13 ` Greg KH
2005-06-06 23:53 ` Jeff Garzik
2005-06-06 23:56 ` Greg KH
2005-06-06 23:58 ` David S. Miller
2005-06-07 4:24 ` Grant Grundler
2005-06-07 0:18 ` Roland Dreier
2005-06-07 5:21 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-06-07 22:33 Nguyen, Tom L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050607052202.GD17734@suse.de \
--to=gregkh@suse.de \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=roland@topspin.com \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.