From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Scott Parish" Subject: Re: [patch] predicate NX flag Date: Tue, 7 Jun 2005 20:47:16 +0000 Message-ID: <20050607204716.GC14747@us.ibm.com> References: <7F740D512C7C1046AB53446D37200173042FEC74@scsmsx402.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <7F740D512C7C1046AB53446D37200173042FEC74@scsmsx402.amr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Nakajima, Jun" Cc: xen-devel@lists.xensource.com, Scott Parish List-Id: xen-devel@lists.xenproject.org On Tue, Jun 07, 2005 at 01:45:45PM -0700, Nakajima, Jun wrote: > Scott Parish wrote: > > the NX flag should only be set when its use is enabled. > > > > sRp > > Rather than changing __PAGE_KERNEL, I think we should change set_p?d (? > = g, u, m, e) like > > #define set_pmd(pmdptr, pmdval) xen_l2_entry_update(pmdptr, (pmdval)& > __supported_pte_mask) Working on a patch.. there are places that xen_l1_entry_update() is called directly with __PAGE_KERNEL, should those be converted to a set_pte, or should xen_l1_entry_update be updated instead of the macros, or should '& __supported_pte_mask' be hardcoded into these places. I'd prefer to just modify the xen_l?_entry_update()s btw, __supported_PTE_mask seems an unfortunate name for a mask that gets used for other pagetable levels. sRp -- Scott Parish Signed-off-by: srparish@us.ibm.com