All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch 2.6.12-rc6] b44: check link state during open
@ 2005-06-08 19:11 John W. Linville
  0 siblings, 0 replies; only message in thread
From: John W. Linville @ 2005-06-08 19:11 UTC (permalink / raw)
  To: linux-kernel, netdev; +Cc: jgarzik

Check the link state during b44_open.  This closes a 1 HZ window
that existed after b44_open ran but before the b44_timer handler ran,
during which ethtool would report "Link detected: yes" no matter what
the link state actually was.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

 drivers/net/b44.c |    3 +++
 1 files changed, 3 insertions(+)

--- linux-2.6.12-rc6/drivers/net/b44.c.orig	2005-06-08 14:52:35.000000000 -0400
+++ linux-2.6.12-rc6/drivers/net/b44.c	2005-06-08 14:52:43.000000000 -0400
@@ -1285,6 +1285,9 @@ static int b44_open(struct net_device *d
 	b44_init_hw(bp);
 	bp->flags |= B44_FLAG_INIT_COMPLETE;
 
+	netif_carrier_off(dev);
+	b44_check_phy(bp);
+
 	spin_unlock_irq(&bp->lock);
 
 	init_timer(&bp->timer);
-- 
John W. Linville
linville@tuxdriver.com

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-06-08 19:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-08 19:11 [patch 2.6.12-rc6] b44: check link state during open John W. Linville

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.