From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Scott Parish" Subject: Re: [patch] nx bit shouldn't get set when disabled Date: Wed, 8 Jun 2005 19:47:45 +0000 Message-ID: <20050608194745.GG3182@us.ibm.com> References: <7F740D512C7C1046AB53446D37200173042FECD1@scsmsx402.amr.corp.intel.com> <20050608180615.GF14747@us.ibm.com> <0a4bf36fcc19f04c377301f2c4cdff33@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <0a4bf36fcc19f04c377301f2c4cdff33@cl.cam.ac.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, "Nakajima, Jun" , Scott Parish List-Id: xen-devel@lists.xenproject.org On Wed, Jun 08, 2005 at 08:56:32PM +0100, Keir Fraser wrote: > Why does x86_64 get pte_mfn, but not pae i386? I think pci-dma.c > should probably be shared between i386 and x86/64. Last time i checked, the linux side of i386 pae wasn't merged into bk, so i have nothing to test such a patch against. I'll plan on getting a pae setup going again and sending a patch to gerd. > Why the extra mask ops with __supported_pte_mask? Native x86/64 builds > obviously don't need them... Definitions such as __PAGE_KERNEL set NX, but as Jun pointed out, those should only be set when NX mode is enabled. sRp -- Scott Parish Signed-off-by: srparish@us.ibm.com