All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Scott Parish" <srparish@us.ibm.com>
To: "Nakajima, Jun" <jun.nakajima@intel.com>
Cc: xen-devel@lists.xensource.com, Scott Parish <srparish@us.ibm.com>
Subject: Re: [patch] nx bit shouldn't get set when disabled
Date: Wed, 8 Jun 2005 22:33:46 +0000	[thread overview]
Message-ID: <20050608223345.GG14747@us.ibm.com> (raw)
In-Reply-To: <7F740D512C7C1046AB53446D37200173043350F1@scsmsx402.amr.corp.intel.com>

On Wed, Jun 08, 2005 at 03:47:01PM -0700, Nakajima, Jun wrote:

> Agree on that part. Should read like:
> 
>   pte = pte_offset_kernel(pmd, (vstart + (i*PAGE_SIZE)));
> + pte->pte &= __supported_pte_mask;
>   pfn = pte->pte >> PAGE_SHIFT;

I dissent. Same reason as yesterday: the above might work right now, but
as soon as we enable NX the NX bit will end up in the pfn/mfn.

sRp

-- 
Scott Parish
Signed-off-by: srparish@us.ibm.com

  reply	other threads:[~2005-06-08 22:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-08 22:47 [patch] nx bit shouldn't get set when disabled Nakajima, Jun
2005-06-08 22:33 ` Scott Parish [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-06-09 15:02 Nakajima, Jun
2005-06-08 23:29 Nakajima, Jun
2005-06-08 21:56 Nakajima, Jun
2005-06-08 22:00 ` Keir Fraser
2005-06-08 21:30 Ian Pratt
2005-06-08 21:28 ` Keir Fraser
2005-06-07 21:02 [patch] predicate NX flag Nakajima, Jun
2005-06-08 18:06 ` [patch] nx bit shouldn't get set when disabled Scott Parish
2005-06-08 19:56   ` Keir Fraser
2005-06-08 19:47     ` Scott Parish
2005-06-08 21:23       ` Keir Fraser
     [not found]         ` <20050608204727.GH3182@us.ibm.com>
     [not found]           ` <d246c2258805470a73cb0b357f3a6739@cl.cam.ac.uk>
2005-06-08 22:39             ` Scott Parish
2005-06-09 12:59         ` Scott Parish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050608223345.GG14747@us.ibm.com \
    --to=srparish@us.ibm.com \
    --cc=jun.nakajima@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.