From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Scott Parish" <srparish@us.ibm.com>
Subject: Re: [patch] nx bit shouldn't get set when disabled
Date: Wed, 8 Jun 2005 22:33:46 +0000
Message-ID: <20050608223345.GG14747@us.ibm.com>
References: <7F740D512C7C1046AB53446D37200173043350F1@scsmsx402.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <7F740D512C7C1046AB53446D37200173043350F1@scsmsx402.amr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Nakajima, Jun" <jun.nakajima@intel.com>
Cc: xen-devel@lists.xensource.com, Scott Parish <srparish@us.ibm.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, Jun 08, 2005 at 03:47:01PM -0700, Nakajima, Jun wrote:

> Agree on that part. Should read like:
> 
>   pte = pte_offset_kernel(pmd, (vstart + (i*PAGE_SIZE)));
> + pte->pte &= __supported_pte_mask;
>   pfn = pte->pte >> PAGE_SHIFT;

I dissent. Same reason as yesterday: the above might work right now, but
as soon as we enable NX the NX bit will end up in the pfn/mfn.

sRp

-- 
Scott Parish
Signed-off-by: srparish@us.ibm.com