All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] How can I skip i2c detection?
Date: Thu, 09 Jun 2005 23:08:39 +0000	[thread overview]
Message-ID: <20050609230759.44315ad7.khali@linux-fr.org> (raw)
In-Reply-To: <F06EB2894F3F0D45AD9BEA7246DE9C90854F15@WCSEXCMBS1.ad.wabtec.com>

Hi Ben,

> Well, if it's not too much of a bother, I'd like that.
> Using hwmon-sysfs.h would clean that module up a bit, too. =)

Patch is already on its way to -mm :)

http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-02-i2c/i2c-device-attr-lm83.patch

> I looked into doing this briefly, but didn't see a clean way to
> support both chips.

I'll look into it, but I can't see any difficulty. What do you think
they are? It should only be a matter of not creating the sysfs files
which aren't needed on the LM82 (which is a subset of the LM83 IIRC).

> As for detection...
> On the LM82, temperatures 2 and 4 always read 127. (The spec says
> otherwise.)
> Register 0xFF (the stepping) is 3 (same as LM83) so that can't be
> used. So maybe the detection could be to read temp 2 & 4 and if they
> are both 127, then it is a lm82?
> I hope that helps.

Yes it does, but I'm a bit surprised. You said you had to force the lm83
driver. If the LM82 and LM83 chips have the same ID, this shouldn't be
needed. Could you please check which test made by the lm83 driver was
failing? This may be used to differenciate between both chips. Using the
temperatures may not work, as a LM83 with no diodes connected would
probably have 127 too.

Thanks,
-- 
Jean Delvare

  parent reply	other threads:[~2005-06-09 23:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-09 17:52 [lm-sensors] How can I skip i2c detection? BGardner
2005-06-09 18:52 ` Jean Delvare
2005-06-09 22:04 ` BGardner
2005-06-09 22:27 ` Jean Delvare
2005-06-09 22:55 ` BGardner
2005-06-09 23:08 ` Jean Delvare [this message]
2005-06-09 23:47 ` BGardner
2005-06-10  9:22 ` Jean Delvare
2005-06-10 16:55 ` BGardner
2005-06-10 20:43 ` Jean Delvare
2005-06-10 21:49 ` BGardner
2005-06-12  9:15 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050609230759.44315ad7.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.