All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tommy M. McGuire" <mcguire@crsr.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: [PATCH] Re: "git cvsimport"
Date: Fri, 10 Jun 2005 01:22:06 -0500	[thread overview]
Message-ID: <20050610062206.GA3992@immutable.crsr.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0506071556000.2286@ppc970.osdl.org>

On Tue, Jun 07, 2005 at 04:03:53PM -0700, Linus Torvalds wrote:
> I'd love it if somebody tested the remote case (and, if it works, sends me
> a patch that just removes the anal tests in git-cvsimport-script), and
> maybe even updated the information a bit more.. As it is, that
> Documentation/cvs-migration.txt file is a bit on the light side.
> 
> Finally, I don't know what to do about cvsps options. It seems that the 
> default time-fuzz is a bit too long for some projects, so at least that 
> one should be overridable. So my silly script is not exactly wonderful, 
> but I think it's more approachable than people doing the magic by hand 
> (and forgetting to set TZ to UTC and the "-A" flag etc etc).
> 
> 		Linus

This is the first of a short sequence of patches, which just removes the
tests in in git-cvs-import-script.  It does, indeed, just work.

Signed-off-by: Tommy McGuire <mcguire@crsr.net>

Remove unneeded sanity tests, allowing remote CVS repos.

---
commit 21b4b44a5deee7985f14d0f4776ad0d489092a96
tree a48fbf33e90511554077f2c18053f1c000c2edb5
parent 98a96b00b88ee35866cd0b1e94697db76bd5ddf9
author Tommy M. McGuire <mcguire@crsr.net> Thu, 09 Jun 2005 13:12:25 -0500
committer Tommy M. McGuire <mcguire@crsr.net> Thu, 09 Jun 2005 13:12:25 -0500

 git-cvsimport-script |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-cvsimport-script b/git-cvsimport-script
--- a/git-cvsimport-script
+++ b/git-cvsimport-script
@@ -7,7 +7,7 @@ fi
 
 export CVSROOT="$1"
 export MODULE="$2"
-if [ ! "$CVSROOT" ] || [ ! "$MODULE" ] || [ ! -d $CVSROOT ] || [ ! -d $CVSROOT/CVSROOT ] || [ ! -d $CVSROOT/$MODULE ] ; then
+if [ ! "$CVSROOT" ] || [ ! "$MODULE" ] ; then
 	echo "Usage: git cvsimport <cvsroot> <module>"
 	exit 1
 fi


\f
!-------------------------------------------------------------flip-



  parent reply	other threads:[~2005-06-10  6:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-07 23:03 "git cvsimport" Linus Torvalds
2005-06-08  5:32 ` Tommy M. McGuire
2005-06-10  6:22 ` Tommy M. McGuire [this message]
2005-06-10  6:27   ` [PATCH] git cvsimport sanity checking Tommy M. McGuire
2005-06-10  6:33   ` [PATCH] cvs-migration.txt Tommy M. McGuire
2005-06-10  6:38   ` [PATCH] git cvsimport fuzz argument Tommy M. McGuire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050610062206.GA3992@immutable.crsr.net \
    --to=mcguire@crsr.net \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.