All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.org>
To: Wakko Warner <wakko@animx.eu.org>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: Problem found: kaweth fails to work on 2.6.12-rc[456]
Date: Sun, 12 Jun 2005 09:57:55 +0200	[thread overview]
Message-ID: <200506120957.55214.oliver@neukum.org> (raw)
In-Reply-To: <20050612004136.GA8107@animx.eu.org>

Am Sonntag, 12. Juni 2005 02:41 schrieb Wakko Warner:
> After doing some testing, I believe a patch that went into rc4 broke kaweth.
> The kaweth driver itself did not change from rc2 through rc6.
> 
> As a test, I reverted a patch that went into rc4 which modified
> net/core/link_watch.c.  Once I compiled the kernel, my netgear EA101 works
> again.
> 
> The following is the patch that caused it to stop working:
> --- BEGIN PATCH ---
> diff -urN linux-2.6.12-rc3/net/core/link_watch.c linux-2.6.12-rc4/net/core/link_watch.c
> --- linux-2.6.12-rc3/net/core/link_watch.c	2005-03-01 23:37:30.000000000 -0800
> +++ linux-2.6.12-rc4/net/core/link_watch.c	2005-05-06 22:59:27.439802792 -0700
> @@ -74,6 +75,12 @@
>  		clear_bit(__LINK_STATE_LINKWATCH_PENDING, &dev->state);
>  
>  		if (dev->flags & IFF_UP) {
> +			if (netif_carrier_ok(dev)) {
> +				WARN_ON(dev->qdisc_sleeping == &noop_qdisc);
> +				dev_activate(dev);
> +			} else
> +				dev_deactivate(dev);
> +
>  			netdev_state_change(dev);
>  		}
>  
> --- END PATCH ---
> The above is not cut'n'paste.  There was 1 other addition (an include) that
> I removed from the patch inorder to revert it.  The patch above was applied
> to 2.6.12-rc6 using -Rp1.  This is why I believe that kaweth is broken. 
> With my limited understanding of the kernel, it would appear that kaweth
> doesn't support netif_carrier_ok properly.  
> Anyway, I found what caused it to break, but at this point, I do not have
> the required knowledge to do a proper fix.

static void int_callback(struct urb *u, struct pt_regs *regs)
is supposed to handle the link state. Maybe it fails in your case. Could you
add a printk to this callback to check linkstate?

	Regards
		Oliver
 

  parent reply	other threads:[~2005-06-12  7:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-12  0:41 Problem found: kaweth fails to work on 2.6.12-rc[456] Wakko Warner
2005-06-12  1:16 ` Wakko Warner
2005-06-12  7:57 ` Oliver Neukum [this message]
2005-06-12 13:05   ` Wakko Warner
2005-06-12 15:22     ` Oliver Neukum
2005-06-15  1:02       ` Wakko Warner
2005-06-15  6:29         ` Oliver Neukum
2005-06-15 11:31           ` Wakko Warner
2005-06-15 11:30             ` Oliver Neukum
2005-06-15 16:53               ` Wakko Warner
2005-06-15 16:52                 ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200506120957.55214.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=wakko@animx.eu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.