Re: network driver disabled interrupts in PREEMPT_RT

[Ingo Molnar <mingo@elte.hu>]

* Kristian Benoit <kbenoit@opersys.com> wrote:

> Hi,
> I got lots of these messages when accessing the net running
> 2.6.12-rc6-RT-V0.7.48-25 :
> 
> "network driver disabled interrupts: tg3_start_xmit+0x0/0x629 [tg3]"
> 
> it seem to come from net/sched/sch_generic.c.

does the patch below fix it?

	Ingo

--- linux/drivers/net/tg3.c.orig
+++ linux/drivers/net/tg3.c
@@ -3242,9 +3242,9 @@ static int tg3_start_xmit(struct sk_buff
 	 * So we really do need to disable interrupts when taking
 	 * tx_lock here.
 	 */
-	local_irq_save(flags);
+	local_irq_save_nort(flags);
 	if (!spin_trylock(&tp->tx_lock)) { 
-		local_irq_restore(flags);
+		local_irq_restore_nort(flags);
 		return NETDEV_TX_LOCKED; 
 	}