All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Greg KH <greg@kroah.com>
Cc: Reiner Sailer <sailer@watson.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	LSM <linux-security-module@wirex.com>,
	Tom Lendacky <toml@us.ibm.com>, Chris Wright <chrisw@osdl.org>,
	Emily Rattlif <emilyr@us.ibm.com>,
	Kylene Hall <kylene@us.ibm.com>
Subject: Re: [PATCH] 4 of 5 IMA: module measurement patch
Date: Wed, 15 Jun 2005 15:14:51 -0700	[thread overview]
Message-ID: <20050615221451.GR9046@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050615215823.GA539@kroah.com>

* Greg KH (greg@kroah.com) wrote:
> On Wed, Jun 15, 2005 at 10:57:23AM -0400, Reiner Sailer wrote:
> > +extern int ima_terminating;
> > +extern void measure_kernel_module(void *start, unsigned long len, const char __user *uargs);
> 
> These belong in a .h file somewhere.

Well, I think they _are_ in a .h file (two of them, in fact), it's the
extern keyword that can be and dup declaration that can be dropped.
However, does this thing even compile w/ CONFIG_IMA_MEASURE=n?
Looks quite broken w.r.t. CONFIG_IMA_MEASURE to me.

thanks,
-chris

      reply	other threads:[~2005-06-15 22:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-15 14:57 [PATCH] 4 of 5 IMA: module measurement patch Reiner Sailer
2005-06-15 21:58 ` Greg KH
2005-06-15 22:14   ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050615221451.GR9046@shell0.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=emilyr@us.ibm.com \
    --cc=greg@kroah.com \
    --cc=kylene@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@wirex.com \
    --cc=sailer@watson.ibm.com \
    --cc=toml@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.