All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Young <sean@mess.org>
To: Joern Engel <joern@wohnheim.fh-wedel.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] Embedded bios FTL
Date: Thu, 16 Jun 2005 13:54:59 +0200	[thread overview]
Message-ID: <20050616115459.GA70753@atlantis.8hz.com> (raw)
In-Reply-To: <20050616102905.GA2166@wohnheim.fh-wedel.de>

On Thu, Jun 16, 2005 at 12:29:05PM +0200, Joern Engel wrote:
> On Thu, 16 June 2005 11:15:46 +0200, Sean Young wrote:

-snip chucking unused sectors-

> > Indeed so. Besides, it would be more elegant if the file system driver 
> > passed this on to the block device, via an ioctl. Would such a thing
> > stand up to scrutiny? As far as I can see, only the ftl block devices 
> > would benefit.
> 
> An ioctl() would have a *really* hard time to make it into the kernel.

I agree that ioctl()s are ugly, but it does have the advantage that it 
is accessible from user-space. Excuse my ignorance, but what is the 
motivation for this?

> What you could do, however, might be something similar to this:
> 
> o Add an erase() function to stuct block_device_operations
> o Have fat call that function whenever a block is know unused.
> o Make sure only to call the function, if it's non-NULL.  Maybe a
>   wrapper, maybe just
> 	if (bd_ops->erase)
> 		bd_ops->erase(block);
>   inside fs/fat/.
> o Implement erase() for your ftl driver to do something smart.
> 
> Be careful, though.  I haven't worked on block devices for a very long
> time and could be talking out of my arse.  If you send such a patch to
> akpm and get flamed into a pile of ashes - don't blame me. ;)

I'll have to spend more time looking at the block devices/bio code 
before I can start. :)

erase() sounds rather mtd-specific. Wouldn't stale() be better?


Sean

  reply	other threads:[~2005-06-16 11:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-12 14:47 [PATCH] Embedded bios FTL Sean Young
2005-06-13 12:36 ` Jörn Engel
2005-06-14 19:28   ` Sean Young
2005-06-14 22:18     ` Jörn Engel
2005-06-15 19:27       ` Sean Young
2005-06-15 21:01         ` Jörn Engel
2005-06-16  9:15           ` Sean Young
2005-06-16 10:28             ` David Woodhouse
2005-06-16 10:29             ` Jörn Engel
2005-06-16 11:54               ` Sean Young [this message]
2005-06-16 12:44                 ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050616115459.GA70753@atlantis.8hz.com \
    --to=sean@mess.org \
    --cc=joern@wohnheim.fh-wedel.de \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.