From: Greg KH <greg@kroah.com>
To: Abhay Salunke <Abhay_Salunke@dell.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
matt_domsch@dell.com
Subject: Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver
Date: Thu, 16 Jun 2005 11:52:02 -0700 [thread overview]
Message-ID: <20050616185202.GA11657@kroah.com> (raw)
In-Reply-To: <20050615175946.GA1495@littleblue.us.dell.com>
On Wed, Jun 15, 2005 at 12:59:46PM -0500, Abhay Salunke wrote:
> +static struct device rbu_device_mono;
> +static struct device rbu_device_packet;
> +static struct device rbu_device_cancel;
You should never create a struct device on the stack. Lots of bad
things can happen (including not having a release function for them.)
Why not just point to the cpu device, or some other platform or system
device?
thanks,
greg k-h
next prev parent reply other threads:[~2005-06-16 18:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-15 17:59 [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver Abhay Salunke
2005-06-16 18:52 ` Greg KH [this message]
2005-06-20 0:36 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2005-07-20 23:50 [patch 2.6.12-rc3]dell_rbu: " Abhay Salunke
2005-07-09 1:07 Abhay Salunke
2005-06-17 14:55 [patch 2.6.12-rc3] dell_rbu: " Abhay_Salunke
2005-06-17 15:29 ` Greg KH
2005-06-02 23:26 Abhay Salunke
2005-06-02 23:58 ` Marcel Holtmann
2005-06-03 12:32 ` Andreas Henriksson
2005-06-05 21:51 ` Jesper Juhl
2005-06-02 18:36 Abhay Salunke
2005-06-02 21:44 ` Marcel Holtmann
2005-05-26 18:43 Abhay_Salunke
2005-05-26 16:37 Abhay_Salunke
2005-05-26 16:56 ` Matt Domsch
2005-05-26 20:37 ` Greg KH
2005-05-26 21:36 ` Marcel Holtmann
2005-05-23 14:52 Abhay_Salunke
2005-05-23 14:58 ` Arjan van de Ven
2005-05-23 14:59 ` Marcel Holtmann
2005-05-23 15:48 ` Greg KH
2005-05-19 12:03 Abhay_Salunke
2005-05-19 14:42 ` Greg KH
2005-05-18 18:13 Abhay Salunke
2005-05-19 3:32 ` Greg KH
2005-05-13 19:00 Abhay Salunke
2005-05-13 21:11 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050616185202.GA11657@kroah.com \
--to=greg@kroah.com \
--cc=Abhay_Salunke@dell.com \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt_domsch@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.