From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: kaos@ocs.com.au, linux-kernel@vger.kernel.org, sam@ravnborg.org
Subject: Re: [patch 2.6.12] Add -Wno-pointer-sign to HOSTCFLAGS
Date: Sun, 19 Jun 2005 10:58:33 +0100 [thread overview]
Message-ID: <20050619105833.C6499@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200506190923.j5J9Nbq0011676@harpo.it.uu.se>; from mikpe@csd.uu.se on Sun, Jun 19, 2005 at 11:23:37AM +0200
On Sun, Jun 19, 2005 at 11:23:37AM +0200, Mikael Pettersson wrote:
> On Sun, 19 Jun 2005 11:50:03 +1000, Keith Owens wrote:
> >Compiling 2.6.12 with gcc 4.0.0 (FC4) gets lots of warnings for the
> >programs in the scripts directory. Add -Wno-pointer-sign to HOSTCFLAGS
> >to suppress them.
> >
> >Signed-off-by: Keith Owens <kaos@ocs.com.au>
> >
> >Index: 2.6.12/Makefile
> >===================================================================
> >--- 2.6.12.orig/Makefile 2005-06-18 15:21:18.000000000 +1000
> >+++ 2.6.12/Makefile 2005-06-19 11:43:15.876218980 +1000
> >@@ -204,6 +204,8 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH"
> > HOSTCC = gcc
> > HOSTCXX = g++
> > HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
> >+# disable pointer signedness warnings in gcc 4.0
> >+HOSTCFLAGS += $(call cc-option,-Wno-pointer-sign,)
> > HOSTCXXFLAGS = -O2
>
> Please don't. Bogus code should be fixed, not hidden.
cc-option checks to see if the flag is supported by $(CC) which could
be a completely different compiler from $(HOSTCC). Hence the above
can incorrectly supply/fail to supply the argument.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-06-19 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-19 9:23 [patch 2.6.12] Add -Wno-pointer-sign to HOSTCFLAGS Mikael Pettersson
2005-06-19 9:58 ` Russell King [this message]
2005-06-19 10:32 ` Keith Owens
2005-07-03 19:22 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2005-06-19 1:50 Keith Owens
2005-06-20 2:02 ` Jeff Garzik
2005-07-03 19:26 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050619105833.C6499@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.