From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] init_module / cleanup_module cleanup
Date: Sun, 19 Jun 2005 19:50:59 +0000 [thread overview]
Message-ID: <20050619195059.GB6455@nd47.coderock.org> (raw)
In-Reply-To: <42984D00.8070003@reiner-h.de>
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]
Sorry it took so long for me to reply.
On 29/05/05 15:42 +0200, Reiner Herrmann wrote:
> Domen Puncer wrote:
> > Missing "Signed-off-by:";
> > Patch should probably be split per dir (diffsplit -d) and if some patch
> > touches >1 file of a driver, per driver.
> In my opinion in this case it is OK, if there is only one patch,
> because I did only a single logical change to these files.
Still it makes some sense to put wireless, tokenring etc. in
different patches. But i'm just nitpicking.
>
> > Also, diffstat -p1 when patching multiple files is great.
> > (http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt is a nice
> > read).
> Thank you for the hint. I'll use this tool from now on.
>
> >>diff -uprN vanilla-2.6.12-rc5-kj/drivers/net/wireless/wavelan.c linux-2.6.12-rc5-kj/drivers/net/wireless/wavelan.c
> >>--- vanilla-2.6.12-rc5-kj/drivers/net/wireless/wavelan.c 2005-03-02 08:38:26.000000000 +0100
> >>+++ linux-2.6.12-rc5-kj/drivers/net/wireless/wavelan.c 2005-05-28 01:10:59.000000000 +0200
> >
> >
> > This one (and probably some others) won't compile on !MODULE, because
> > it includes wavelan.p.h with variables only defined on MODULE.
> >
> > An ugly hack i used to quickly compile test it:
> > egrep "^--- " ~/netdrivers_module_cleanup.diff | cut -f2 -d' '| cut -f1 | cut -f2- -d'/' | sed 's/.c$/.o/g' | xargs -n1 make 2>&1
>
> The appended patch should now be correct.
Doesn't look like, on at least !MODULE:
domen@nd47:~/kernel/a$ wc -l netdrivers_*
399 netdrivers_not_patched
429 netdrivers_patched
828 total
domen@nd47:~/kernel/a$ grep error -c netdrivers_*
netdrivers_not_patched:113
netdrivers_patched:128
A nice example is tms380tr which compiled cleanly before, but fails
now.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-06-19 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-28 10:50 [KJ] init_module / cleanup_module cleanup Reiner Herrmann
2005-05-28 13:13 ` Domen Puncer
2005-05-28 18:20 ` randy_dunlap
2005-05-29 13:42 ` Reiner Herrmann
2005-06-19 19:50 ` Domen Puncer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050619195059.GB6455@nd47.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.