From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org
Subject: [-mm patch] fs/fscache/: cleanups
Date: Mon, 20 Jun 2005 01:38:04 +0200 [thread overview]
Message-ID: <20050619233803.GX21393@stusta.de> (raw)
This patch contains the following cleanups:
- make needlessly global code static
- main.c: remove the unused global variable fscache_debug
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 23 Apr 2005
fs/fscache/cookie.c | 19 +++++++++++++++----
fs/fscache/fscache-int.h | 11 -----------
fs/fscache/main.c | 2 --
3 files changed, 15 insertions(+), 17 deletions(-)
--- linux-2.6.12-rc2-mm3-full/fs/fscache/fscache-int.h.old 2005-04-23 02:53:14.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/fs/fscache/fscache-int.h 2005-04-23 02:55:11.000000000 +0200
@@ -22,17 +22,6 @@
extern void fscache_cookie_init_once(void *_cookie, kmem_cache_t *cachep, unsigned long flags);
-extern void __fscache_cookie_put(struct fscache_cookie *cookie);
-
-static inline void fscache_cookie_put(struct fscache_cookie *cookie)
-{
- BUG_ON(atomic_read(&cookie->usage) <= 0);
-
- if (atomic_dec_and_test(&cookie->usage))
- __fscache_cookie_put(cookie);
-
-}
-
/*****************************************************************************/
/*
* debug tracing
--- linux-2.6.12-rc2-mm3-full/fs/fscache/cookie.c.old 2005-04-23 02:53:26.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/fs/fscache/cookie.c 2005-04-23 02:55:39.000000000 +0200
@@ -12,14 +12,25 @@
#include <linux/module.h>
#include "fscache-int.h"
-LIST_HEAD(fscache_netfs_list);
-LIST_HEAD(fscache_cache_list);
-DECLARE_RWSEM(fscache_addremove_sem);
+static LIST_HEAD(fscache_netfs_list);
+static LIST_HEAD(fscache_cache_list);
+static DECLARE_RWSEM(fscache_addremove_sem);
kmem_cache_t *fscache_cookie_jar;
static void fscache_withdraw_node(struct fscache_cache *cache,
struct fscache_node *node);
+static void __fscache_cookie_put(struct fscache_cookie *cookie);
+
+
+static inline void fscache_cookie_put(struct fscache_cookie *cookie)
+{
+ BUG_ON(atomic_read(&cookie->usage) <= 0);
+
+ if (atomic_dec_and_test(&cookie->usage))
+ __fscache_cookie_put(cookie);
+
+}
/*****************************************************************************/
/*
@@ -925,7 +936,7 @@
/*
* destroy a cookie
*/
-void __fscache_cookie_put(struct fscache_cookie *cookie)
+static void __fscache_cookie_put(struct fscache_cookie *cookie)
{
struct fscache_search_result *srch;
--- linux-2.6.12-rc2-mm3-full/fs/fscache/main.c.old 2005-04-23 02:55:48.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/fs/fscache/main.c 2005-04-23 02:56:22.000000000 +0200
@@ -16,8 +16,6 @@
#include <linux/slab.h>
#include "fscache-int.h"
-int fscache_debug = 0;
-
static int fscache_init(void);
static void fscache_exit(void);
next reply other threads:[~2005-06-19 23:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-19 23:38 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-27 19:51 [-mm patch] fs/fscache/: cleanups Adrian Bunk
2005-07-17 14:57 Adrian Bunk
2005-04-23 4:16 Adrian Bunk
2005-04-25 9:51 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050619233803.GX21393@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.