All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: jejb@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH, scsi-block-2.6] remove bio_map_user
Date: Mon, 20 Jun 2005 12:37:13 +0200	[thread overview]
Message-ID: <20050620103709.GA15021@suse.de> (raw)
In-Reply-To: <20050619092946.GA16872@lst.de>

On Sun, Jun 19 2005, Christoph Hellwig wrote:
> It's only used by blk_rq_map_user and that's the only sensible caller.

That's not really true, there is/are valid uses of bio_map_user() alone.

> So do the iov wrapping there and kill bio_map_user.

While I do agree with the change, I know of external users of
bio_map_user(). It's a really trivial piece of code, so I would rather
just let bio_map_user() stay as-is.


-- 
Jens Axboe


  reply	other threads:[~2005-06-20 10:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-19  9:29 [PATCH, scsi-block-2.6] remove bio_map_user Christoph Hellwig
2005-06-20 10:37 ` Jens Axboe [this message]
2005-06-20 10:36   ` Christoph Hellwig
2005-06-20 10:41     ` Jens Axboe
2005-06-20 10:42       ` Christoph Hellwig
2005-06-20 10:59         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050620103709.GA15021@suse.de \
    --to=axboe@suse.de \
    --cc=hch@lst.de \
    --cc=jejb@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.