All of lore.kernel.org
 help / color / mirror / Atom feed
From: domen@coderock.org
To: rmk@arm.linux.org.uk
Cc: linux-kernel@vger.kernel.org,
	Nishanth Aravamudan <nacc@us.ibm.com>,
	domen@coderock.org
Subject: [patch 4/4] arm/cpu-sa1110: replace schedule_timeout() with msleep()
Date: Mon, 20 Jun 2005 23:49:27 +0200	[thread overview]
Message-ID: <20050620214926.542498000@nd47.coderock.org> (raw)

[-- Attachment #1: msleep-arch_arm_mach-sa1100_cpu-sa1110.patch --]
[-- Type: text/plain, Size: 859 bytes --]

From: Nishanth Aravamudan <nacc@us.ibm.com>



Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected. Neither signals nor wait-queue events are important at this
point in the code, I believe.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
 cpu-sa1110.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

Index: quilt/arch/arm/mach-sa1100/cpu-sa1110.c
===================================================================
--- quilt.orig/arch/arm/mach-sa1100/cpu-sa1110.c
+++ quilt/arch/arm/mach-sa1100/cpu-sa1110.c
@@ -271,8 +271,7 @@ static int sa1110_target(struct cpufreq_
 	 */
 	sdram_set_refresh(2);
 	if (!irqs_disabled()) {
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout(20 * HZ / 1000);
+		msleep(20);
 	} else {
 		mdelay(20);
 	}

--

             reply	other threads:[~2005-06-20 22:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-20 21:49 domen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-03-05 22:41 [patch 4/4] arm/cpu-sa1110: replace schedule_timeout() with msleep() domen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050620214926.542498000@nd47.coderock.org \
    --to=domen@coderock.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nacc@us.ibm.com \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.