From: domen@coderock.org
To: emoenke@gwdg.de
Cc: linux-kernel@vger.kernel.org,
Nishanth Aravamudan <nacc@us.ibm.com>,
domen@coderock.org
Subject: [patch 3/4] cdrom/sjcd: remove sleep_on() usage
Date: Mon, 20 Jun 2005 23:51:49 +0200 [thread overview]
Message-ID: <20050620215149.610416000@nd47.coderock.org> (raw)
[-- Attachment #1: sleep_on-drivers_cdrom_sjcd.patch --]
[-- Type: text/plain, Size: 1185 bytes --]
From: Nishanth Aravamudan <nacc@us.ibm.com>
Directly use wait-queues instead of the deprecated sleep_on().
This required adding a local waitqueue. Patch is compile-tested.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
sjcd.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletion(-)
Index: quilt/drivers/cdrom/sjcd.c
===================================================================
--- quilt.orig/drivers/cdrom/sjcd.c
+++ quilt/drivers/cdrom/sjcd.c
@@ -70,6 +70,7 @@
#include <linux/string.h>
#include <linux/major.h>
#include <linux/init.h>
+#include <linux/wait.h>
#include <asm/system.h>
#include <asm/io.h>
@@ -407,9 +408,12 @@ static void sjcd_status_timer(void)
*/
static int sjcd_wait_for_status(void)
{
+ DEFINE_WAIT(wait);
sjcd_status_timeout = SJCD_WAIT_FOR_STATUS_TIMEOUT;
SJCD_SET_TIMER(sjcd_status_timer, 1);
- sleep_on(&sjcd_waitq);
+ prepare_to_wait(&sjcd_waitq, &wait, TASK_UNINTERRUPTIBLE);
+ schedule();
+ finish_wait(&sjcd_waitq, &wait);
#if defined( SJCD_DIAGNOSTIC ) || defined ( SJCD_TRACE )
if (sjcd_status_timeout <= 0)
printk("SJCD: Error Wait For Status.\n");
--
reply other threads:[~2005-06-20 23:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050620215149.610416000@nd47.coderock.org \
--to=domen@coderock.org \
--cc=emoenke@gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.