From: domen@coderock.org
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: linux-fsdevel@vger.kernel.org,
Nishanth Aravamudan <nacc@us.ibm.com>,
domen@coderock.org
Subject: [patch 4/7] fs/clntproc: replace schedule_timeout() with msleep_interruptible()
Date: Mon, 20 Jun 2005 23:57:03 +0200 [thread overview]
Message-ID: <20050620215702.999768000@nd47.coderock.org> (raw)
[-- Attachment #1: msleep_interruptible-fs_lockd_clntproc.patch --]
[-- Type: text/plain, Size: 1091 bytes --]
From: Nishanth Aravamudan <nacc@us.ibm.com>
Use msleep_interruptible() instead of schedule_timeout(). The
existing code is not incorrect, but msleep_interruptible() offers two
advantages: 1) consistency across the kernel and 2) human-sensible time units
(msecs).
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
clntproc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Index: quilt/fs/lockd/clntproc.c
===================================================================
--- quilt.orig/fs/lockd/clntproc.c
+++ quilt/fs/lockd/clntproc.c
@@ -14,6 +14,7 @@
#include <linux/nfs_fs.h>
#include <linux/utsname.h>
#include <linux/smp_lock.h>
+#include <linux/delay.h>
#include <linux/sunrpc/clnt.h>
#include <linux/sunrpc/svc.h>
#include <linux/lockd/lockd.h>
@@ -298,8 +299,7 @@ nlmclnt_alloc_call(void)
return call;
}
printk("nlmclnt_alloc_call: failed, waiting for memory\n");
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(5*HZ);
+ msleep_interruptible(5000);
}
return NULL;
}
--
reply other threads:[~2005-06-20 22:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050620215702.999768000@nd47.coderock.org \
--to=domen@coderock.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nacc@us.ibm.com \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.