All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Domen Puncer <domen@coderock.org>,
	axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [patch 04/12] block/xd: replace schedule_timeout() with msleep()
Date: Tue, 21 Jun 2005 09:14:52 -0700	[thread overview]
Message-ID: <20050621161452.GA4175@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.61L.0506211451180.9446@blysk.ds.pg.gda.pl>

On 21.06.2005 [14:53:49 +0100], Maciej W. Rozycki wrote:
> On Tue, 21 Jun 2005, Domen Puncer wrote:
> 
> > mdelay - busy loop
> > msleep - schedule
> 
>  Right -- that's my mistake.  But what's the point of the change in the 
> first place anyway?  The original code is correct.

Please refer to the comment in the description:

schedule_timeout(1) is ambiguous in older/unchanged code since 2.4, as
it indicated a 10 millisecond sleep then. Now, in 2.6, it indicates a 1
millisecond sleep (HZ==1000). I am trying to prevent issues like this
coming up in the future (CONFIG_HZ has hit -mm, e.g.) and msleep() is a
good way to do so.

If you are trying to sleep for the shortest amount of time possible (a
tick), though, then the code is fine, I guess. A comment may be useful,
though.

Thanks,
Nish

  reply	other threads:[~2005-06-21 16:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-20 21:51 [patch 04/12] block/xd: replace schedule_timeout() with msleep() domen
2005-06-21 11:39 ` Maciej W. Rozycki
2005-06-21 13:21   ` Domen Puncer
2005-06-21 13:53     ` Maciej W. Rozycki
2005-06-21 16:14       ` Nishanth Aravamudan [this message]
2005-06-21 16:43         ` Maciej W. Rozycki
2005-06-21 18:29           ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050621161452.GA4175@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=axboe@suse.de \
    --cc=domen@coderock.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.