Re: [patch 1/16] s390: klist bus_find_device & driver_find_device callback.

[Greg KH <gregkh@suse.de>]

On Wed, Jun 22, 2005 at 09:11:02AM +0100, Christoph Hellwig wrote:
> > +struct device * bus_find_device(struct bus_type * bus, struct device * start,
> > +				void * data, int (*match)(struct device *, void *))
> > +{
> > +	struct klist_iter i;
> > +	struct device * dev;
> > +
> > +	if (!bus)
> > +		return NULL;
> > +
> > +	klist_iter_init_node(&bus->klist_devices, &i,
> > +			     (start ? &start->knode_bus : NULL));
> > +	while ((dev = next_device(&i)))
> > +		if (match(dev, data))
> > +			break;
> > +	klist_iter_exit(&i);
> > +	return dev;
> 
> does the klist magic somehow grab a reference for you?

No, see my previous comment about the need for this to be fixed for
these two functions.

thanks,

greg k-h