Re: [PATCH 10/11] ppc64: SPU file system

[Arnd Bergmann <arnd@arndb.de>]

On Middeweken 22 Juni 2005 02:21, Hollis Blanchard wrote:
> On Jun 21, 2005, at 4:34 PM, Arnd Bergmann wrote:
> 
> > +union MFC_TagSizeClassCmd {
> 
> I think great effort has gone in to removing so-called "StudlyCaps" 
> from the ppc64 iSeries code... :)

Yes. I've been wanting to fix this one for ages, but it keeps
slipping through. The file used to be shared with user space
(bad idea) and the CPU simulator and I tried to at least keep
the structure definitions compatible initially.

> Also, I didn't see "MFC" defined anywhere... it's sort of a pet peeve, 
> but could you make sure all your acronyms are defined? Most of them are 
> described in spu.h, but a few slipped through I think (like "SMF").

good point

> And while a comment at the top of every file is great, ones like this:
> > +/*
> > + * Low-level SPU handling
> > + *
> might be more helpful if they defined SPU and further mentioned it's 
> the coprocessor in the Broadband Processor Architecture...

Yes, all this is the sort of stuff you never notice unless you take
while working on a piece of code for months.

Thanks,

	Arnd <><