All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Knorr <kraxel@suse.de>
To: xen-devel@lists.xensource.com
Subject: [patch] pae: build fix
Date: Wed, 22 Jun 2005 16:00:25 +0200	[thread overview]
Message-ID: <20050622140025.GA31707@bytesex> (raw)

  Hi,

The patch below is needed to make pae-enabled xen build.  Not
sure why the intpte_t cast was added and whenever it is a good
idea to remove it.  Problem is that PAGE_MASK is used to
page-align both physical and virtual addresses, and the cast
causes build failures for the virtual address case.

Comments?

  Gerd

Index: xen/include/asm-x86/page.h
===================================================================
--- xen.orig/include/asm-x86/page.h	2005-06-20 12:45:29.000000000 +0200
+++ xen/include/asm-x86/page.h	2005-06-20 16:32:34.000000000 +0200
@@ -7,7 +7,8 @@
 #else
 #define PAGE_SIZE           (1 << PAGE_SHIFT)
 #endif
-#define PAGE_MASK           (~(intpte_t)(PAGE_SIZE-1))
+//#define PAGE_MASK           (~(intpte_t)(PAGE_SIZE-1))
+#define PAGE_MASK           (~(PAGE_SIZE-1))
 #define PAGE_FLAG_MASK      (~0U)
 
 #ifndef __ASSEMBLY__

             reply	other threads:[~2005-06-22 14:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-22 14:00 Gerd Knorr [this message]
2005-06-22 14:51 ` [patch] pae: build fix Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050622140025.GA31707@bytesex \
    --to=kraxel@suse.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.