All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dipankar Sarma <dipankar@in.ibm.com>
To: "Artem B. Bityuckiy" <dedekind@oktetlabs.ru>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] files: change fd_install assertion
Date: Fri, 24 Jun 2005 19:39:18 +0530	[thread overview]
Message-ID: <20050624140918.GA4562@in.ibm.com> (raw)
In-Reply-To: <42BC10C9.9020309@oktetlabs.ru>

On Fri, Jun 24, 2005 at 05:55:21PM +0400, Artem B. Bityuckiy wrote:
> Dipankar Sarma wrote:
> >Because that way the compare and branch can be ifdefed out when CONFIG_BUG 
> >is
> >not set. Not to mention BUG_ON() looks more like an assertion.
> 
> Surely, even if BUG() will be nothing, the compiler will optimize that?
> Yes, it looks better, but I don't like that there was unlikely() before 
> and you removed it. I'ts minor though.

I did not. BUG_ON() is supposed to have unlikely() inside. See the
generic version. If an arch specific BUG_ON() doesn't have some
branch hint, it definitely should.

Thanks
Dipankar

  reply	other threads:[~2005-06-24 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-24 10:50 [PATCH 0/4] files: various updates Dipankar Sarma
2005-06-24 10:52 ` [PATCH 1/4] files: fix dupfd by fdt reload Dipankar Sarma
2005-06-24 10:53   ` [PATCH 2/4] files: fix expand_files return code Dipankar Sarma
2005-06-24 10:54     ` [PATCH 3/4] files: change fd_install assertion Dipankar Sarma
2005-06-24 10:55       ` [PATCH 4/4] files: doc update Dipankar Sarma
2005-06-24 12:04       ` [PATCH 3/4] files: change fd_install assertion Artem B. Bityuckiy
2005-06-24 13:00         ` Dipankar Sarma
2005-06-24 13:55           ` Artem B. Bityuckiy
2005-06-24 14:09             ` Dipankar Sarma [this message]
2005-06-24 14:20               ` Artem B. Bityuckiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050624140918.GA4562@in.ibm.com \
    --to=dipankar@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=dedekind@oktetlabs.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.