From mboxrd@z Thu Jan  1 00:00:00 1970
From: Flavio Leitner <fbl@conectiva.com.br>
Subject: Re: libxc/load_aou9.c signness fix gcc4
Date: Fri, 24 Jun 2005 17:40:44 -0300
Message-ID: <20050624204043.GJ3577@conectiva.com.br>
References: <1119644189.2747.6.camel@thinkpad>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <1119644189.2747.6.camel@thinkpad>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jerone Young <jyoung5@us.ibm.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org



There are bit shifting operations inside of=20
get_header() that, imho, will break if you
turn image signed.=20


On Fri, Jun 24, 2005 at 03:16:28PM -0500, Jerone Young wrote:
> another gcc sign fix.
>=20
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> --- tools/libxc/xc_load_aout9.c.old     2005-06-24 14:50:16.000000000
> -0500
> +++ tools/libxc/xc_load_aout9.c 2005-06-24 15:02:08.000000000 -0500
> @@ -19,7 +19,7 @@
>  static int parseaout9image(char *, unsigned long, struct
> domain_setup_info *);
>  static int loadaout9image(char *, unsigned long, int, u32, unsigned
> long *, struct domain_setup_info *);
>  static void copyout(int, u32, unsigned long *, unsigned long, void *,
> int);
> -struct Exec *get_header(unsigned char *, unsigned long, struct Exec *)=
;
> +struct Exec *get_header(char *, unsigned long, struct Exec *);
>=20
>=20
>  int
> @@ -139,7 +139,7 @@ copyout(
>   */
>  struct Exec *
>  get_header(
> -    unsigned char *image,
> +    char *image,
>      unsigned long image_size,
>      struct Exec *ehdr)
>  {
>=20
> --=20
> Jerone Young
> IBM Linux Technology Center
> jyoung5@us.ibm.com
> 512-838-1157 (T/L: 678-1157)
>=20
>=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

--=20
Fl=E1vio Bruno Leitner <fbl@conectiva.com.br>
[0EA2 7F40 4CF4 1E63 4AF6  33C0 3E10 E205 F251 EDDA]