All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Warne <nick@linicks.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow number of IDE interfaces to be selected (X86)
Date: Sun, 26 Jun 2005 21:34:56 +0100	[thread overview]
Message-ID: <200506262134.57000.nick@linicks.net> (raw)
In-Reply-To: <1119808554.28649.37.camel@localhost.localdomain>

On Sunday 26 June 2005 18:55, you wrote:

> I don't think this patch should go in - the one real reason for having
> it in embedded boxes was saving memory. The right fix for that is
> already something Bartlomiej has talked about fixing - the static
> allocation of the ide_hwifs array itself.

OK :-).

But I learnt a lot here on the kernel.

Also found not to cut 'n' paste from nano in X.  It doesn't perserve tabs... 
so the patch was bum anyway.  I only found out it was fubar when I was 
looking at what Matt done to get the struct sizes on different vmlinuz 
builds, and cut and paste back into a file from the mail.

But here is the results anyway using my .config but with the option off and 
on:


Orig (off):

bash-2.05b# nm -t d -rS --size-sort linux-2.6.12orig/vmlinux | grep hwifs
0000003225966208 0000000000014080 B ide_hwifs


With the IDE selection option (but not EMBEDDED) with 2 IDE interfaces 
selected (on with 2):

bash-2.05b# nm -t d -rS --size-sort linux-2.6.12/vmlinux | grep hwifs
0000003225974400 0000000000002816 B ide_hwifs


Nick
-- 
"When you're chewing on life's gristle,
Don't grumble, Give a whistle..."

  reply	other threads:[~2005-06-26 20:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-25 15:41 [PATCH] Allow number of IDE interfaces to be selected (X86) Nick Warne
2005-06-26 17:55 ` Alan Cox
2005-06-26 20:34   ` Nick Warne [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-06-25 17:22 Nick Warne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200506262134.57000.nick@linicks.net \
    --to=nick@linicks.net \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.