From: Bob Picco <bob.picco@hp.com>
To: akpm@osdl.org
Cc: linux-mm@kvack.org, bob.picco@hp.com
Subject: [PATCH] fix WANT_PAGE_VIRTUAL in memmap_init
Date: Mon, 27 Jun 2005 06:58:29 -0400 [thread overview]
Message-ID: <20050627105829.GX23911@localhost.localdomain> (raw)
I spotted this issue while in memmap_init last week. I can't say the change has
any test coverage by me. start_pfn was formerly used in main "for" loop.
The fix is replace start_pfn with pfn.
bob
Signed-off-by: Bob Picco <bob.picco@hp.com>
Index: linux-2.6.12-mm1/mm/page_alloc.c
===================================================================
--- linux-2.6.12-mm1.orig/mm/page_alloc.c 2005-06-23 14:18:09.000000000 -0400
+++ linux-2.6.12-mm1/mm/page_alloc.c 2005-06-23 14:19:46.000000000 -0400
@@ -1720,9 +1720,8 @@ void __init memmap_init_zone(unsigned lo
#ifdef WANT_PAGE_VIRTUAL
/* The shift won't overflow because ZONE_NORMAL is below 4G. */
if (!is_highmem_idx(zone))
- set_page_address(page, __va(start_pfn << PAGE_SHIFT));
+ set_page_address(page, __va(pfn << PAGE_SHIFT));
#endif
- start_pfn++;
#ifdef CONFIG_PAGE_OWNER
page->order = -1;
#endif
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next reply other threads:[~2005-06-27 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-27 10:58 Bob Picco [this message]
2005-06-27 12:58 ` [PATCH] fix WANT_PAGE_VIRTUAL in memmap_init William Lee Irwin III
2005-06-27 13:04 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050627105829.GX23911@localhost.localdomain \
--to=bob.picco@hp.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.