All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-pcmcia@lists.infradead.org
Subject: pcmcia: release_class patch concern
Date: Mon, 27 Jun 2005 23:56:49 -0500	[thread overview]
Message-ID: <200506272356.50029.dtor_core@ameritech.net> (raw)

Hi Dominik,

I noticed that Linus committed the patch from you that introduces waiting
for completion in module's exit routine. I believe it is a big no-no as
something like this will wedge the kernel:

	rmmod <module> < /sys/path/to/devices/attribute

Have you considered using Greg's class_create()/class_destroy() or maybe
bumping up module's refrerence count when registering class devices so
rmmod would fail if there are users of this module?

-- 
Dmitry

             reply	other threads:[~2005-06-28  4:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-28  4:56 Dmitry Torokhov [this message]
2005-06-28  6:14 ` pcmcia: release_class patch concern Dominik Brodowski
2005-06-28  6:41   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200506272356.50029.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=linux@dominikbrodowski.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.