Re: [patch] ide dma blacklist toshiba

[maximilian attems <janitor@sternwelten.at>]

On Tue, 28 Jun 2005, Jens Axboe wrote:

> On Tue, Jun 28 2005, Jeff Garzik wrote:
> > Jens Axboe wrote:
> > >On Sun, Jun 26 2005, Jeff Garzik wrote:
> > >
> > >>maximilian attems wrote:
> > >>
> > >>>--- kernel-source-2.6.6/drivers/ide/ide-dma.c	2004-04-05 
> > >>>19:49:28.000000000 +1000
> > >>>+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c	2004-04-05 
> > >>>20:54:34.000000000 +1000
> > >>>@@ -125,6 +125,7 @@
> > >>>	{ "HITACHI CDR-8335"	,	"ALL"		},
> > >>>	{ "HITACHI CDR-8435"	,	"ALL"		},
> > >>>	{ "Toshiba CD-ROM XM-6202B"	,	"ALL"		},
> > >>>+	{ "TOSHIBA CD-ROM XM-1702BC"	,	"ALL"		},
> > >>>	{ "CD-532E-A"		,	"ALL"		},
> > >>>	{ "E-IDE CD-ROM CR-840",	"ALL"		},
> > >>>	{ "CD-ROM Drive/F5A",	"ALL"		},
> > >>
> > >>
> > >>When touching the blacklist, always make sure to patch 
> > >>ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or 
> > >>aonther patch mailed at the same time).
> > >
> > >
> > >This has come up at least two times in the last week already, how about
> > >adding a unified dma blacklist to ata.h instead?
> > 
> > Feel free to submit a patch :)
> 
> Hehe, somehow I knew that was going to be the response :-)
> 
> -- 
> Jens Axboe

if you haven't done it yet, i'll spin one next weekend.
 
--
maks