From: Jean Delvare <khali@linux-fr.org>
To: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Cc: akpm@osdl.org, video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] V4L CX88 patch - against 2.6.12-mm2
Date: Tue, 28 Jun 2005 23:21:57 +0200 [thread overview]
Message-ID: <20050628232157.214c76fd.khali@linux-fr.org> (raw)
In-Reply-To: <42C19F6A.6020501@brturbo.com.br>
Hi Mauro,
Your patch adds trailing whitespace in various places:
> - core->tuner_type, core->tuner_addr<<1,
> + core->tuner_type, core->tuner_addr<<1,
> - ir->mask_keycode = 0x8f8;
> + ir->mask_keycode = 0x8f8;
> - ir->mask_keycode = 0x1f;
> + ir->mask_keycode = 0x1f;
> -static int or51132_set_ts_param(struct dvb_frontend* fe,
> +static int or51132_set_ts_param(struct dvb_frontend* fe,
Six people signing this patch and nobody noticed? Amazing.
Please fix, thanks.
--
Jean Delvare
next prev parent reply other threads:[~2005-06-28 21:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 19:05 [PATCH 1/1] V4L CX88 patch - against 2.6.12-mm2 Mauro Carvalho Chehab
2005-06-28 21:21 ` Jean Delvare [this message]
2005-06-28 21:30 ` Andrew Morton
2005-06-28 21:49 ` Mauro Carvalho Chehab
2005-06-28 22:10 ` Alexey Dobriyan
2005-07-17 3:57 ` David Lloyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050628232157.214c76fd.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.