From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262484AbVF2HyQ (ORCPT ); Wed, 29 Jun 2005 03:54:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262470AbVF2HxA (ORCPT ); Wed, 29 Jun 2005 03:53:00 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:15568 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S262480AbVF2HuW (ORCPT ); Wed, 29 Jun 2005 03:50:22 -0400 Date: Wed, 29 Jun 2005 08:50:19 +0100 From: Christoph Hellwig To: Pekka J Enberg Cc: Christoph Hellwig , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: freevxfs: minor cleanups Message-ID: <20050629075019.GA17982@infradead.org> Mail-Followup-To: Christoph Hellwig , Pekka J Enberg , Andrew Morton , linux-kernel@vger.kernel.org References: <20050628163114.6594e1e1.akpm@osdl.org> <1120018821.9658.4.camel@localhost> <20050629070814.GC16850@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 29, 2005 at 10:42:39AM +0300, Pekka J Enberg wrote: > > I agree that pointer initialization is not really an issue but I do prefer > the C99 struct initializers over an kcalloc(1, sizeof(*p)) call. > > Is this something you don't want for freevxfs or filesystems in general? > Should it be removed from NTFS as well? I don't have control over NTFS, but please don't introduce this idiom anywhere else.