Re: [KJ] [PATCH 2.6.12] [RESEND] /proc/tty/driver/* filtering for non

From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 2.6.12] [RESEND] /proc/tty/driver/* filtering for non
Date: Wed, 29 Jun 2005 10:42:58 +0000	[thread overview]
Message-ID: <20050629104258.GF3904@nd47.coderock.org> (raw)
In-Reply-To: <20050622194756.GA6699@dansme-mobile.smertnig>

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

On 22/06/05 21:47 +0200, Daniel Smertnig wrote:
> Only give out non-sensitive information to CAP_SYS_RAWIO users in
> /proc/tty/driver/* and make it world-readable, as described in the
> kernel janitors TODO:
> 
> Signed-off-by: Daniel Smertnig <daniel.smertnig@gmail.com>
> 
> diff --git a/drivers/char/amiserial.c b/drivers/char/amiserial.c
> --- a/drivers/char/amiserial.c
> +++ b/drivers/char/amiserial.c
> @@ -1876,6 +1876,17 @@ static inline int line_info(char *buf, s
>  		info->quot = 0;
>  		info->tty = NULL;
>  	}
> +
> +	if (info->quot) {
> +		ret += sprintf(buf+ret, " baud:%d",
> +			       state->baud_base / info->quot);
> +	}
> +
> +	if (!capable(CAP_SYS_RAWIO)) {
> +		strcat(buf, "\n");
> +		return ret + 1;

So... we overwrite first two bytes, and then return the whole string?
Or am I missing something?

> +	}
> +	

   ^^ you introduce whitespace.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors