From: Andi Kleen <ak@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
matthew@wil.cx, ak@suse.de, hch@lst.de, akpm@osdl.org,
linux-arch@vger.kernel.org
Subject: Re: RFC: is_compat_task
Date: Wed, 29 Jun 2005 14:12:28 +0200 [thread overview]
Message-ID: <20050629121228.GH21575@bragg.suse.de> (raw)
In-Reply-To: <20050629164127.58e97376.sfr@canb.auug.org.au>
On Wed, Jun 29, 2005 at 04:41:27PM +1000, Stephen Rothwell wrote:
> On Tue, 28 Jun 2005 13:47:36 -0700 (PDT) "David S. Miller" <davem@davemloft.net> wrote:
> >
> > Why don't we do the following to resolve this issue?
> > Create a "is_compat_syscall()" macro, in compat syscall
> > trap entry, the bit is set, and it is cleared otherwise.
> >
> > It nops out to always evaluate to "0" on non-compat platforms.
>
> How about the patch below which defines is_compat_syscall() for ppc64 (and
> all the non-compat-requiring archs)? (Yes, the ppc64 syscall entry really
> checks the thread flag.) The patch alos includes the fixes for the input
> layer mess.
> for the other 64 bit architectures.
I think for the particular input case it would be still better
to just define ->compat_write at the VFS level.
This would require a new compat_sys_write() wrapper, but that would
be straight forward.
-Andi
next prev parent reply other threads:[~2005-06-29 12:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 7:27 input compat stuff Christoph Hellwig
2005-06-28 8:14 ` RFC: is_compat_task (Was: Re: input compat stuff) Stephen Rothwell
2005-06-28 8:30 ` RFC: is_compat_task David S. Miller
2005-06-28 9:17 ` RFC: is_compat_task (Was: Re: input compat stuff) Andi Kleen
2005-06-28 9:23 ` RFC: is_compat_task David S. Miller
2005-06-28 9:27 ` Andi Kleen
2005-06-28 9:29 ` David S. Miller
2005-06-28 9:33 ` Andi Kleen
2005-06-28 11:18 ` RFC: is_compat_task (Was: Re: input compat stuff) Matthew Wilcox
2005-06-28 12:05 ` Andi Kleen
2005-06-28 20:47 ` RFC: is_compat_task David S. Miller
2005-06-29 6:41 ` Stephen Rothwell
2005-06-29 11:01 ` Arnd Bergmann
2005-06-29 12:12 ` Andi Kleen [this message]
2005-06-30 7:57 ` Stephen Rothwell
2005-06-30 8:42 ` Andi Kleen
2005-06-30 14:38 ` Stephen Rothwell
2005-06-30 15:28 ` Stephen Rothwell
2005-06-30 15:49 ` Andi Kleen
2005-06-30 23:29 ` Paul Mackerras
2005-07-01 2:34 ` David S. Miller
2005-07-01 13:48 ` Andi Kleen
2005-07-04 3:36 ` Paul Mackerras
2005-07-04 23:02 ` David S. Miller
2005-07-01 4:56 ` [PATCH, for review 1/3] compat_sys_{read,write} Stephen Rothwell
2005-07-01 4:58 ` [PATCH, for review 2/3] hook up compat_sys_{read,write} syscalls Stephen Rothwell
2005-07-01 5:01 ` [PATCH, for review 3/3] fix evdev Stephen Rothwell
2005-07-01 7:58 ` [PATCH, for review 1/3] compat_sys_{read,write} David Howells
2005-07-01 8:24 ` Stephen Rothwell
2005-07-21 7:05 ` Stephen Rothwell
2005-07-21 8:05 ` David S. Miller
2005-07-21 8:28 ` Stephen Rothwell
2005-06-29 10:36 ` RFC: is_compat_task Andi Kleen
2005-06-28 16:09 ` RFC: is_compat_task (Was: Re: input compat stuff) Stephen Rothwell
2005-06-28 16:14 ` Andi Kleen
2005-06-28 16:34 ` Stephen Rothwell
2005-06-28 16:44 ` Andi Kleen
2005-06-30 10:16 ` Ralf Baechle
2005-06-28 9:16 ` input compat stuff Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050629121228.GH21575@bragg.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=linux-arch@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.