From: Arun Sharma <arun.sharma@intel.com>
To: Ian Pratt <Ian.Pratt@cl.cam.ac.uk>,
Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: [PATCH][10/10] Use copy_from_user when accessing guest_pt[]
Date: Wed, 29 Jun 2005 22:53:29 -0700 [thread overview]
Message-ID: <20050630055329.GA7509@intel.com> (raw)
Use copy_from_user when accessing guest_pt[]
Signed-off-by: Arun Sharma <arun.sharma@intel.com>
diff -r 2d289d7ab961 -r d0eccea63a24 xen/arch/x86/shadow.c
--- a/xen/arch/x86/shadow.c Thu Jun 30 05:26:09 2005
+++ b/xen/arch/x86/shadow.c Thu Jun 30 05:26:24 2005
@@ -1906,7 +1906,7 @@
unsigned long gpfn, unsigned index)
{
unsigned long smfn = __shadow_status(d, gpfn, PGT_snapshot);
- l1_pgentry_t *snapshot; // could be L1s or L2s or ...
+ l1_pgentry_t *snapshot, gpte; // could be L1s or L2s or ...
int entries_match;
perfc_incrc(snapshot_entry_matches_calls);
@@ -1916,10 +1916,14 @@
snapshot = map_domain_page(smfn);
+ if (__copy_from_user(&gpte, &guest_pt[index],
+ sizeof(gpte)))
+ return 0;
+
// This could probably be smarter, but this is sufficent for
// our current needs.
//
- entries_match = !l1e_has_changed(guest_pt[index], snapshot[index],
+ entries_match = !l1e_has_changed(gpte, snapshot[index],
PAGE_FLAG_MASK);
unmap_domain_page(snapshot);
reply other threads:[~2005-06-30 5:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050630055329.GA7509@intel.com \
--to=arun.sharma@intel.com \
--cc=Ian.Pratt@cl.cam.ac.uk \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.