From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DnxBE-0004qC-9H for mharc-grub-devel@gnu.org; Thu, 30 Jun 2005 07:26:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DnxB7-0004nF-1l for grub-devel@gnu.org; Thu, 30 Jun 2005 07:25:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DnxAw-0004j1-TX for grub-devel@gnu.org; Thu, 30 Jun 2005 07:25:53 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DnxAt-0004aZ-Ti for grub-devel@gnu.org; Thu, 30 Jun 2005 07:25:44 -0400 Received: from [200.19.162.16] (helo=leao.natalnet.br) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1DnxC8-0006ZU-LX for grub-devel@gnu.org; Thu, 30 Jun 2005 07:27:01 -0400 Received: from localhost (storm.dca.ufrn.br [10.13.99.250]) by leao.natalnet.br (8.12.8/8.12.8) with ESMTP id j5UBLpPp003611 for ; Thu, 30 Jun 2005 08:21:51 -0300 Date: Thu, 30 Jun 2005 08:21:49 -0300 From: Rodrigo =?ISO-8859-1?Q?Steinm=FCller?= Wanderley To: The development of GRUB 2 Message-ID: <20050630082149.5e7ea0fb@localhost> In-Reply-To: <42C2B09C.1050007@yahoo.fr> References: <42C2B09C.1050007@yahoo.fr> Organization: NatalNet - UFRN X-Mailer: Sylpheed-Claws 1.0.4 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Natalnet-MailScanner-Information: Please contact the administrator for more information X-Natalnet-MailScanner: Found to be clean X-Natalnet-MailScanner-SpamCheck: not spam, SpamAssassin (score=-100, required 7, USER_IN_WHITELIST -100.00) Subject: Re: [PATCH 1/2] Various cleanups in kern/misc.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2005 11:26:00 -0000 Hi Vicent, Just one small comment here... I know its silly, but: 29/06 as 16:30: Vincent escreveu: VP> static char * VP> -grub_itoa (char *str, int c, unsigned n) VP> +grub_itoa (char *str, int c, unsigned int n) VP> { VP> - unsigned base = (c == 'x') ? 16 : 10; VP> + unsigned int base = (c == 'x') ? 16 : 10, d; VP> char *p; VP> VP> if ((int) n < 0 && c == 'd') VP> { VP> - n = (unsigned) (-((int) n)); VP> + n = (unsigned int) (-((int) n)); VP> *str++ = '-'; VP> } VP> VP> p = str; VP> do VP> { VP> - unsigned d = n % base; VP> + d = n % base; VP> *p++ = (d > 9) ? d + 'a' - 10 : d + '0'; VP> } I think p is not necessary. Specially because we already used str to walk through the string in the first if. What do you think? VP> while (n /= base); VP> @@ -500,9 +515,9 @@ grub_itoa (char *str, int c, unsigned n) VP> } -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.4.1 (GNU/Linux) mQGiBEKJ288RBAD43+VlxMx8V0dLbU+f7TsbhknjBYp2sRMP0a8IkHa8z4DgJTRd XRMB0D05Hp5iE/1cA8t3e+g2J4kQhcj1JgUA6KSpYcj/cX6EKb6xhb/GAEQupaXz 7RYglwf4Sz9WJA3roSLtQuWcCOYR9lys+kifeTE2jnDLzDcuzwa2pEYJbwCg04jF uyOmiBd09P1Bgq4VOQhYM78D/j0Iyj0QIstssnRPWcg4QL9l5c7Y8rLRH63qfGOi fakmmY6C1JnW/wm4+2iUOc0/DbM+kKS5yXsiRFW7CDeqXLUEF1NIRvNaHkmfRmQf shDI8NJCr0ULMbUde3b1U0LKgMRr7uVnVRFb2bPkEFh1mDEaxpy376+2Rpn8uHOu GvqYBACJzY7EPP0fFQMMxeSyxHA7A/lxmC9/s1YtRgBHTCniYOQIZ+kwbFrU9XQv ExvMeO2DvYAtDNyCgV/PaUm0yLxCAmxSVxQaAMRkOuMSKatyBggLpJVZKQ4WuayL 3xA+ws2+F2ozC/LHK9DodkGen35lP286QyPXOV2WciE4YciU3bQsUm9kcmlnbyBT IFdhbmRlcmxleSA8cndhbmRlcmxleUBuYXRhbG5ldC5icj6IZAQTEQIAJAUCQonb zwIbAwUJAeEzgAYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBuM/JKbknmQugDAKC6 ZfWsa8qone19+oppGBkrX028QACfUfLi9rSs/qxmE77b0P+xa2IrWN25Ag0EQonb 2xAIANBkeWLFcVSxSCsCQEH8HJ80VhQO18Sy80MpXebf9sj1gwUATZJ/OcxYYw46 ZrFwNk9raTRULprAcqR5ORKk3TNZ6ZnEl337PZZS5FnELwsHXTm+KVKF3bE2nnB5 /25SzPwkidsyk8Pe3HYM9/r4dwHNOXE3i0nYsweC/aUE8yg/3Ipweu9K1cj+XbSM IpDydOmBpvVhIvv+VOIoevXxgm2hrD7LQ7jnfBaj/bV9GY/tJyl50nWgMM7csaAg +4H1lG5/FvzNOgudmhzAdMk5lyTMLyRj6wiYkvckvBCXFaC04FgseylRj72NZilQ xIstJWNomiATkC6uHYtOKExZ1xcAAwUIALTSG+l21w/W3L9iuEi8QK91n7LyHoO/ OJpYbj73sJWsui7qG63os8aR+KgbdbKNFGDwkyYfbfildYDd+TOkFWkbT64vq4Wv t51Pl2dB0+0cnO/xqRnbxt4II7SBwg5t1u/MHahaULoTcTYslN+bW9FuB9I22ZiJ pzFddDWjWApggNQIEapCd+XiuYnED6rV+n0GcmZxpb9Iz0mak7SPCZvN3QzPCI/6 k2YZlt92I/k4E2GU9NVM/1mXkTgqVgwOwlunPW6JYgcv/3n2Ly1eMNJQioWGRSnZ wQyVx7FvBUqMGLrWHTw3+FQRDd6B6pQ2Y4uL0W4LskQrXm97hhW5NuKITwQYEQIA DwUCQonb2wIbDAUJAeEzgAAKCRBuM/JKbknmQuXzAKDTa3d+h15/KHHupI6AMkNr YKRP3ACggEq09XZBLGulCU2e6+/I0j4iN3U= =JhUw -----END PGP PUBLIC KEY BLOCK-----