All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: vda@ilport.com.ua, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] deinline sleep/delay functions
Date: Thu, 30 Jun 2005 10:44:45 +0100	[thread overview]
Message-ID: <20050630104445.C13407@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050630021111.35aaf45f.akpm@osdl.org>; from akpm@osdl.org on Thu, Jun 30, 2005 at 02:11:11AM -0700

On Thu, Jun 30, 2005 at 02:11:11AM -0700, Andrew Morton wrote:
> Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > Rejected-by: Russell King 8)
> > 
> > The reason is that now we're unable to find out if anyone's doing
> > udelay(100000000000000000) which breaks on most architectures.
> > 
> > There are a number of compile-time checks that your patch has removed
> > which catch such things, and as such your patch is not acceptable.
> > Some architectures have a lower threshold of acceptability for the
> > maximum udelay value, so it's absolutely necessary to keep this.
> 
> I don't recall seeing anyone trigger the check, and it hardly seems worth
> adding a "few kb" to vmlinux for it?

Maybe we can have both - would the space saving be achieved by just moving
mdelay and ssleep out of linux/delay.h and not touching asm-i386/delay.h?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  parent reply	other threads:[~2005-06-30  9:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-30  5:52 [PATCH] deinline sleep/delay functions Denis Vlasenko
2005-06-30  8:52 ` Russell King
2005-06-30  9:11   ` Andrew Morton
2005-06-30  9:19     ` Arjan van de Ven
2005-06-30 10:21       ` Denis Vlasenko
2005-06-30 10:47         ` Arjan van de Ven
2005-06-30 11:10           ` Denis Vlasenko
2005-06-30 11:21             ` Russell King
2005-06-30 11:22             ` Arjan van de Ven
2005-06-30 11:44               ` Denis Vlasenko
2005-06-30 11:57                 ` Maciej W. Rozycki
2005-06-30 12:04                 ` Russell King
2005-06-30 12:20                   ` Denis Vlasenko
2005-07-01  7:54           ` Vojtech Pavlik
2005-06-30  9:44     ` Russell King [this message]
2005-07-01  7:53 ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050630104445.C13407@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vda@ilport.com.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.