From: Christoph Hellwig <hch@lst.de>
To: J?rn Engel <joern@wohnheim.fh-wedel.de>
Cc: Christoph Hellwig <hch@lst.de>,
cotte@de.ibm.com, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xip cleanups
Date: Thu, 30 Jun 2005 15:46:14 +0200 [thread overview]
Message-ID: <20050630134614.GA14397@lst.de> (raw)
In-Reply-To: <20050628124029.GB7460@wohnheim.fh-wedel.de>
On Tue, Jun 28, 2005 at 02:40:29PM +0200, J?rn Engel wrote:
> I personally prefer the original code. As a general rule, error
> handling code is indented further than regular good-case code. That
> makes reading a *lot* faster and the compiler should be smart enough
> to generate identical code.
ok.. the cast removal is also wrong as Arnd pointed out, btw.
> > - (mapping->host,tmp.b_blocknr*(PAGE_SIZE/512) ,&data);
> > + (mapping->host,tmp.b_blocknr * (PAGE_SIZE/512), &data);
> ^
> You missed one.
feel free to add it :)
next prev parent reply other threads:[~2005-06-30 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 12:01 [PATCH] xip cleanups Christoph Hellwig
2005-06-28 12:40 ` Jörn Engel
2005-06-30 13:46 ` Christoph Hellwig [this message]
[not found] ` <200506281421.09893.arnd@arndb.de>
2005-06-30 13:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050630134614.GA14397@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=cotte@de.ibm.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.