All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: Patrick Jenkins <patjenk@wam.umd.edu>,
	linux-kernel@vger.kernel.org,
	Maillist netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH] multipath routing algorithm, better patch
Date: Fri, 1 Jul 2005 19:41:17 +0200	[thread overview]
Message-ID: <20050701174117.GW16076@postel.suug.ch> (raw)
In-Reply-To: <42C4919A.5000009@trash.net>

* Patrick McHardy <42C4919A.5000009@trash.net> 2005-07-01 02:43
> Multiple algorithms can be compiled in at once, so this patch is wrong.
> mp_alg is supplied by userspace:
> 
>         if (rta->rta_mp_alg) {
>                 mp_alg = *rta->rta_mp_alg;
> 
>                 if (mp_alg < IP_MP_ALG_NONE ||
>                     mp_alg > IP_MP_ALG_MAX)
>                         goto err_inval;
>         }
> 
> If it isn't set correctly its an iproute problem. Did you actually
> experience any problems?

Well, my patch for iproute2 to enable multipath algorithm selection
is currently being merged to Stephen together with the ematch bits.
We had to work out a dependency on GNU flex first (the berkley
version uses the same executable names) so the inclusion was
delayed a bit.

  parent reply	other threads:[~2005-07-01 17:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-01  0:19 [PATCH] multipath routing algorithm, better patch Patrick Jenkins
2005-07-01  0:43 ` Patrick McHardy
2005-07-01  0:43 ` Patrick McHardy
2005-07-01 17:41   ` Thomas Graf
2005-07-01 17:41   ` Thomas Graf [this message]
2005-07-01 19:34     ` Patrick McHardy
2005-07-01 20:46       ` Thomas Graf
2005-07-01 19:34     ` Patrick McHardy
  -- strict thread matches above, loose matches on Subject: below --
2005-07-05 15:17 Patrick Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050701174117.GW16076@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=patjenk@wam.umd.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.