All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: GCC4 warning: no return statement in function returning
Date: Fri, 01 Jul 2005 22:22:51 +0000	[thread overview]
Message-ID: <20050701222251.GB26388@homer.coderock.org> (raw)
In-Reply-To: <20050701221504.GA26388@homer.coderock.org>

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

On 02/07/05 00:15 +0200, Domen Puncer wrote:
> On 01/07/05 11:19 -0700, Jesse Millan wrote:
> > -int kauditd_thread(void *dummy)
> > +void kauditd_thread(void *dummy)
> 
> This should warn too, as kthread_create() (kthread_run()) accepts
> int (*threadfn)(void *data)
> 
> I think kauditd_thread() should be fixed here to return something...
> "The return value should be zero or a negative error number:
>  it will be passed to kthread_stop()."

But it doesn't return at all (d'oh, should have seen this before).
Still... there's a warning if it returns void, right?


	Domen

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2005-07-01 22:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-01 22:15 [KJ] Re: GCC4 warning: no return statement in function returning Domen Puncer
2005-07-01 22:22 ` Domen Puncer [this message]
2005-07-01 22:42 ` [KJ] Re: GCC4 warning: no return statement in function randy_dunlap
2005-07-01 22:59 ` [KJ] Re: GCC4 warning: no return statement in function returning Jesse Millan
2005-07-07 21:14 ` Jesse Millan
2005-07-08 18:21 ` [KJ] Re: GCC4 warning: no return statement in function randy_dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050701222251.GB26388@homer.coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.