From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: shemminger@osdl.org, jgarzik@pobox.com
Subject: Re: [PATCH] skge: remove unused declarations
Date: Fri, 1 Jul 2005 18:51:58 -0400 [thread overview]
Message-ID: <20050701225158.GA6762@redhat.com> (raw)
In-Reply-To: <200506281916.j5SJGi5m012509@hera.kernel.org>
On Tue, Jun 28, 2005 at 12:16:44PM -0700, Linux Kernel wrote:
> tree 6154380f95d261126525fc95eb149ddc8478eeea
> parent 4707953454677f985289b4e4bcbea41f0cc651c2
> author Stephen Hemminger <shemminger@osdl.org> Tue, 28 Jun 2005 01:33:08 -0700
> committer Jeff Garzik <jgarzik@pobox.com> Tue, 28 Jun 2005 02:05:06 -0400
>
> [PATCH] skge: remove unused declarations
>
> Get rid of definitions for chip versions and PHY chips that
> this driver does not support.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
> ...
> - PCI_EN_DUMMY_RD = 1<<3, /* Enable Dummy Read */
> - PCI_REV_DESC = 1<<2, /* Reverse Desc. Bytes */
> - PCI_USEDATA64 = 1<<0, /* Use 64Bit Data bus ext */
> -};
This bit breaks PPC builds, due to ..
3145 #ifdef __BIG_ENDIAN
3146 /* byte swap decriptors in hardware */
3147 {
3148 u32 reg;
3149
3150 pci_read_config_dword(pdev, PCI_DEV_REG2, ®);
3151 reg |= 1 << 2; /* PCI_REV_DESC */
3152 pci_write_config_dword(pdev, PCI_DEV_REG2, reg);
3153 }
3154 #endif
For my builds, I've just hardcoded it, I don't know if you prefer
to put the enum back or not..
Dave
next parent reply other threads:[~2005-07-01 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200506281916.j5SJGi5m012509@hera.kernel.org>
2005-07-01 22:51 ` Dave Jones [this message]
2005-07-05 16:55 ` [PATCH] skge: remove unused declarations Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050701225158.GA6762@redhat.com \
--to=davej@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.