From: Christoph Hellwig <hch@infradead.org>
To: Karim Yaghmour <karim@opersys.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
LTT-Dev <ltt-dev@shafik.org>, Tom Zanussi <zanussi@us.ibm.com>,
Robert Wisniewski <bob@watson.ibm.com>,
Mathieu Desnoyers <compudj@krystal.dyndns.org>,
Michel Dagenais <michel.dagenais@polymtl.ca>,
Michael Raymond <mraymond@sgi.com>
Subject: Re: [PATCH/RFC] Significantly reworked LTT core
Date: Sat, 2 Jul 2005 17:04:45 +0100 [thread overview]
Message-ID: <20050702160445.GA29262@infradead.org> (raw)
In-Reply-To: <42C60001.5050609@opersys.com>
This code is rather pointless. The ltt_mux is doing all the real
work and it's not included. And while we're at it the layering for
it is wrong aswell - the ltt_log_event API should be implemented by
the actual multiplexer with what's in ltt_log_event now minus the
irq disabling becoming a library function.
Exporting a pointer to the root dentry seems like a very wrong API
aswell, that's an implementation detail that should be hidden.
Besides that the code is not following Documentation/CodingStyle
at all, please read it.
Besides that I'd sugest scrapping the ltt name and ltt_ prefix - we know
we're on linux, adn we don't care whether it's a toolkit, but spelling trace_
out would actually be a lot more descriptive. So what about trace_* symbol
names and trace.[ch] filenames?
next prev parent reply other threads:[~2005-07-02 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-02 2:46 [PATCH/RFC] Significantly reworked LTT core Karim Yaghmour
2005-07-02 13:14 ` [ltt-dev] " Michael Raymond
2005-07-02 14:32 ` Karim Yaghmour
2005-07-02 16:06 ` Karim Yaghmour
2005-07-02 16:04 ` Christoph Hellwig [this message]
2005-07-02 21:15 ` Karim Yaghmour
2005-07-07 14:11 ` Christoph Hellwig
2005-07-08 13:20 ` Karim Yaghmour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050702160445.GA29262@infradead.org \
--to=hch@infradead.org \
--cc=bob@watson.ibm.com \
--cc=compudj@krystal.dyndns.org \
--cc=karim@opersys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
--cc=michel.dagenais@polymtl.ca \
--cc=mraymond@sgi.com \
--cc=zanussi@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.