From: Alexey Dobriyan <adobriyan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 2.6.13-rc1 16/17] fix sparse warnings (__nocast type)
Date: Sun, 03 Jul 2005 22:45:00 +0000 [thread overview]
Message-ID: <200507040245.00278.adobriyan@gmail.com> (raw)
In-Reply-To: <200507031906.48856.victor@cetuc.puc-rio.br>
On Sunday 03 July 2005 23:06, Victor Fusco wrote:
> --- linux-2.6-git.orig/drivers/ieee1394/raw1394.c
> +++ linux-2.6-git/drivers/ieee1394/raw1394.c
>
> -static struct pending_request *__alloc_pending_request(int flags)
> +static struct
> +pending_request *__alloc_pending_request(unsigned int __nocast flags)
Very wrong line break. There are two styles in the kernel:
a) struct foo * bar(void)
{
}
b) struct foo *
bar(void)
{
}
drivers/ieee1394/raw1394.c uses a). Stick to it.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-07-03 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-03 19:06 [KJ] [PATCH 2.6.13-rc1 16/17] fix sparse warnings (__nocast type) Victor Fusco
2005-07-03 20:03 ` Victor Fusco
2005-07-03 22:45 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200507040245.00278.adobriyan@gmail.com \
--to=adobriyan@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.