[KJ] [PATCH 2.6.13-rc1 16/17] fix sparse warnings (__nocast type)

[KJ] [PATCH 2.6.13-rc1 16/17] fix sparse warnings (__nocast type)

[Victor Fusco]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

Description:
	Fix the sparse warning "implicit cast to nocast type"
 
File/Subsystem: drivers/ieee1394/raw1394.c

Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>
 

[-- Attachment #2: ieee1394_raw1394.patch --]
[-- Type: text/x-diff, Size: 644 bytes --]

 drivers/ieee1394/raw1394.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6-git/drivers/ieee1394/raw1394.c
===================================================================
--- linux-2.6-git.orig/drivers/ieee1394/raw1394.c	2005-07-01 17:48:31.000000000 +0000
+++ linux-2.6-git/drivers/ieee1394/raw1394.c	2005-07-03 17:06:04.000000000 +0000
@@ -98,7 +98,8 @@
 
 static void queue_complete_cb(struct pending_request *req);
 
-static struct pending_request *__alloc_pending_request(int flags)
+static struct
+pending_request *__alloc_pending_request(unsigned int __nocast flags)
 {
 	struct pending_request *req;
 

[-- Attachment #3: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 2.6.13-rc1 16/17] fix sparse warnings (__nocast type)

[Victor Fusco]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

Em Dom 03 Jul 2005 22:45, Alexey Dobriyan escreveu:
> Very wrong line break. There are two styles in the kernel:
> 
> a)	struct foo * bar(void)
> 	{
> 	}
> 
> b)	struct foo *
> 	bar(void)
> 	{
> 	}
> 
> drivers/ieee1394/raw1394.c uses a). Stick to it.
> 

Oops..

Here is the correction.

Thanks,

Victor Fusco

-------------------------------------------------------------------------------

Description:
        Fix the sparse warning "implicit cast to nocast type"
 
File/Subsystem: drivers/ieee1394/raw1394.c

Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>

[-- Attachment #2: ieee1394_raw1394.patch --]
[-- Type: text/x-diff, Size: 641 bytes --]

 drivers/ieee1394/raw1394.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-git/drivers/ieee1394/raw1394.c
===================================================================
--- linux-2.6-git.orig/drivers/ieee1394/raw1394.c	2005-07-03 19:47:50.000000000 +0000
+++ linux-2.6-git/drivers/ieee1394/raw1394.c	2005-07-03 19:48:43.000000000 +0000
@@ -98,7 +98,7 @@
 
 static void queue_complete_cb(struct pending_request *req);
 
-static struct pending_request *__alloc_pending_request(int flags)
+static struct pending_request *__alloc_pending_request(unsigned int __nocast flags)
 {
 	struct pending_request *req;
 

[-- Attachment #3: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 2.6.13-rc1 16/17] fix sparse warnings (__nocast type)

[Alexey Dobriyan]

On Sunday 03 July 2005 23:06, Victor Fusco wrote:
> --- linux-2.6-git.orig/drivers/ieee1394/raw1394.c
> +++ linux-2.6-git/drivers/ieee1394/raw1394.c
> 
> -static struct pending_request *__alloc_pending_request(int flags)
> +static struct
> +pending_request *__alloc_pending_request(unsigned int __nocast flags)

Very wrong line break. There are two styles in the kernel:

a)	struct foo * bar(void)
	{
	}

b)	struct foo *
	bar(void)
	{
	}

drivers/ieee1394/raw1394.c uses a). Stick to it.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors