From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Small unicode problem fix in normal/menu.c
Date: Tue, 5 Jul 2005 00:42:25 +0200 [thread overview]
Message-ID: <200507050042.25708.okuji@enbug.org> (raw)
In-Reply-To: <42C84FF8.8020102@yahoo.fr>
On Sunday 03 July 2005 22:52, Vincent Pelletier wrote:
> There is an alignment problem when menu is drawn with Unicode chars in
> titles : there aren't enough spaces written on the right to make the
> hilight fill horizontaly the menu.
You can check in this patch, but this is not the right thing to do. At the
moment, it is impossible to know how many columns will be occupied by putting
a byte until it is actually putted. This is very bad, and, of course, does
not work well in some cases.
So, as I described before, it is necessary to implement a new function which
returns the width for a given (Unicode) character. For the menu, I think it
would be easier to convert all strings to Unicode strings before rendering.
Writing bytes is very, very hard.
Okuji
next prev parent reply other threads:[~2005-07-04 22:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-03 20:52 [PATCH] Small unicode problem fix in normal/menu.c Vincent Pelletier
2005-07-04 14:45 ` [Bulk] " Vincent Pelletier
2005-07-04 23:10 ` Yoshinori K. Okuji
2005-07-05 7:03 ` Vincent Pelletier
2005-07-05 10:07 ` Marco Gerards
2005-07-04 22:42 ` Yoshinori K. Okuji [this message]
2005-07-05 20:36 ` Vincent Pelletier
2005-07-09 7:01 ` Yoshinori K. Okuji
2005-07-05 9:58 ` Marco Gerards
2005-07-05 10:46 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200507050042.25708.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.