From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 2.6.13-rc1 14/17] fix sparse warnings (__nocast type)
Date: Tue, 05 Jul 2005 14:00:16 +0000 [thread overview]
Message-ID: <20050705140016.GB2257@homer.coderock.org> (raw)
In-Reply-To: <200507031904.44301.victor@cetuc.puc-rio.br>
[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]
On 03/07/05 19:04 +0000, Victor Fusco wrote:
> Description:
> Fix the sparse warning "implicit cast to nocast type"
>
> File/Subsystem: net/core
>
> Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>
>
> include/linux/security.h | 8 +++++---
How is this related to net/?
> include/linux/skbuff.h | 29 ++++++++++++++++++-----------
> include/net/sock.h | 16 ++++++++++------
> net/core/dev.c | 2 +-
> net/core/skbuff.c | 17 ++++++++++-------
> net/core/sock.c | 11 +++++++----
> 6 files changed, 51 insertions(+), 32 deletions(-)
>
> Index: linux-2.6-git/net/core/skbuff.c
> ===================================================================
> --- linux-2.6-git.orig/net/core/skbuff.c 2005-07-03 16:44:23.000000000 +0000
> +++ linux-2.6-git/net/core/skbuff.c 2005-07-03 17:12:52.000000000 +0000
> @@ -129,7 +129,7 @@
> * Buffers may only be allocated from interrupts using a @gfp_mask of
> * %GFP_ATOMIC.
> */
> -struct sk_buff *alloc_skb(unsigned int size, int gfp_mask)
> +struct sk_buff *alloc_skb(unsigned int size, unsigned int __nocast gfp_mask)
> {
> struct sk_buff *skb;
> u8 *data;
> @@ -182,7 +182,8 @@
> * %GFP_ATOMIC.
> */
> struct sk_buff *alloc_skb_from_cache(kmem_cache_t *cp,
> - unsigned int size, int gfp_mask)
> + unsigned int size,
> + unsigned int __nocast gfp_mask)
Why not tabs in second line too?
Same goes for the rest of patch.
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-07-05 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-03 19:04 [KJ] [PATCH 2.6.13-rc1 14/17] fix sparse warnings (__nocast type) Victor Fusco
2005-07-05 14:00 ` Domen Puncer [this message]
2005-07-05 14:53 ` [KJ] [PATCH 2.6.13-rc1 14/17] fix sparse warnings [UPDATE 1/2] Victor Fusco
2005-07-05 14:53 ` [KJ] [PATCH 2.6.13-rc1 14/17] fix sparse warnings [UPDATE 2/2] Victor Fusco
2005-07-05 16:33 ` Victor Fusco
2005-07-06 18:23 ` [KJ] [PATCH 2.6.13-rc1 14/17] fix sparse warnings [UPDATE 1/2] Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050705140016.GB2257@homer.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.